Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1220813018: [deoptimizer] Properly evict TurboFan OSR code objects on eager deopts. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Properly evict TurboFan OSR code objects on eager deopts. TurboFan OSR installs the CompileOptimized builtin on JSFunctions, which means that we never evict the OSR code objects for such functions from eager deopts. R=jarin@chromium.org Committed: https://crrev.com/c18cf2b43d636d5243d160bab4089aa53a169e8b Cr-Commit-Position: refs/heads/master@{#29507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/runtime/runtime-compiler.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 5 months ago (2015-07-07 07:04:33 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the fix we cooked up. Please take a look. Thanks, Benedikt
5 years, 5 months ago (2015-07-07 07:05:02 UTC) #2
Jarin
lgtm
5 years, 5 months ago (2015-07-07 07:07:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220813018/1
5 years, 5 months ago (2015-07-07 07:09:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-07 07:28:07 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 07:28:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c18cf2b43d636d5243d160bab4089aa53a169e8b
Cr-Commit-Position: refs/heads/master@{#29507}

Powered by Google App Engine
This is Rietveld 408576698