Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 1220813013: This patch enables "mailto" links in WebViews. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc
index fbf9286f7857a457009bff97f6b2b55379f22499..589fe85d7dfcac37efc6bfda56702f5c29c51d49 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc
@@ -814,6 +814,10 @@ void WebViewGuest::DidFailProvisionalLoad(
int error_code,
const base::string16& error_description,
bool was_ignored_by_handler) {
+ // Suppress loadabort for "mailto" URLs.
+ if (validated_url.SchemeIs("mailto"))
lazyboy 2015/07/07 19:32:11 This seems like a hack, can you explain what's goi
paulmeyer 2015/07/08 17:20:16 Yes, it does exactly what happens in a tab. With a
lazyboy 2015/07/10 19:46:50 When we click mailto: from a regular tab page, doe
paulmeyer 2015/07/13 19:47:14 Yes it does, and it ends up calling NavigatorImpl:
+ return;
+
LoadAbort(!render_frame_host->GetParent(), validated_url, error_code,
net::ErrorToShortString(error_code));
}

Powered by Google App Engine
This is Rietveld 408576698