chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc - Issue 1220813013: This patch enables "mailto" links in WebViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

Issue 1220813013: This patch enables "mailto" links in WebViews. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test. Rebased. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | chrome/test/data/extensions/platform_apps/web_view/shim/mailto.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

diff --git a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

index cbccea389687ba2bf3b19ea9876b0f3f3d778a53..fae7d1eb702d0d684cdcd3026ecbf43a5467eefc 100644

--- a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

+++ b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

@@ -511,8 +511,13 @@ bool ChromeResourceDispatcherHostDelegate::HandleExternalProtocol(

ui::PageTransition page_transition,

bool has_user_gesture) {

#if defined(ENABLE_EXTENSIONS)

- if (extensions::WebViewRendererState::GetInstance()->IsGuest(child_id))

+ // External protocols are disabled for guests. An exception is made for the

+ // "mailto" protocol, so that pages that utilize it work properly in a

+ // WebView.

+ if (extensions::WebViewRendererState::GetInstance()->IsGuest(child_id) &&

+ !url.SchemeIs(url::kMailToScheme)) {

return false;

+ }

#endif // defined(ENABLE_EXTENSIONS)

#if defined(OS_ANDROID)