Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1220813013: This patch enables "mailto" links in WebViews. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test. Rebased. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <queue> 5 #include <queue>
6 6
7 #include "base/location.h" 7 #include "base/location.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/process/process.h" 9 #include "base/process/process.h"
10 #include "base/single_thread_task_runner.h" 10 #include "base/single_thread_task_runner.h"
(...skipping 2466 matching lines...) Expand 10 before | Expand all | Expand 10 after
2477 web_view_contents); 2477 web_view_contents);
2478 EXPECT_TRUE(load_success); 2478 EXPECT_TRUE(load_success);
2479 2479
2480 gfx::Rect web_view_container_bounds = web_view_contents->GetContainerBounds(); 2480 gfx::Rect web_view_container_bounds = web_view_contents->GetContainerBounds();
2481 gfx::Rect mime_handler_view_container_bounds = 2481 gfx::Rect mime_handler_view_container_bounds =
2482 mime_handler_view_contents->GetContainerBounds(); 2482 mime_handler_view_contents->GetContainerBounds();
2483 EXPECT_EQ(web_view_container_bounds.origin(), 2483 EXPECT_EQ(web_view_container_bounds.origin(),
2484 mime_handler_view_container_bounds.origin()); 2484 mime_handler_view_container_bounds.origin());
2485 } 2485 }
2486 2486
2487 IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestMailtoLink) {
2488 TestHelper("testMailtoLink", "web_view/shim", NEEDS_TEST_SERVER);
2489 }
2490
2487 #if defined(USE_AURA) 2491 #if defined(USE_AURA)
2488 // TODO(wjmaclean): when WebViewTest is re-enabled on the site-isolation 2492 // TODO(wjmaclean): when WebViewTest is re-enabled on the site-isolation
2489 // bots, then re-enable this test class as well. 2493 // bots, then re-enable this test class as well.
2490 // https://crbug.com/503751 2494 // https://crbug.com/503751
2491 class WebViewFocusTest : public WebViewTest { 2495 class WebViewFocusTest : public WebViewTest {
2492 public: 2496 public:
2493 ~WebViewFocusTest() override {} 2497 ~WebViewFocusTest() override {}
2494 2498
2495 void SetUpCommandLine(base::CommandLine* command_line) override { 2499 void SetUpCommandLine(base::CommandLine* command_line) override {
2496 WebViewTest::SetUpCommandLine(command_line); 2500 WebViewTest::SetUpCommandLine(command_line);
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
2614 // Generate and send synthetic touch event. 2618 // Generate and send synthetic touch event.
2615 FocusWaiter waiter(aura_webview); 2619 FocusWaiter waiter(aura_webview);
2616 content::SimulateTouchPressAt(GetEmbedderWebContents(), 2620 content::SimulateTouchPressAt(GetEmbedderWebContents(),
2617 guest_rect.CenterPoint()); 2621 guest_rect.CenterPoint());
2618 2622
2619 // Wait for the TouchStart to propagate and restore focus. Test times out 2623 // Wait for the TouchStart to propagate and restore focus. Test times out
2620 // on failure. 2624 // on failure.
2621 waiter.Wait(); 2625 waiter.Wait();
2622 } 2626 }
2623 #endif 2627 #endif
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698