chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java - Issue 1220813010: Add UMA metrics to track the source of homescreen icons on launch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

Issue 1220813010: Add UMA metrics to track the source of homescreen icons on launch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing reviewer comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivityTab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

index 1d2ea8a88b5a86cc76bf9db0a80929aa5a2c7993..0d5ca4d166536798505232c421e02d634e2824f7 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

@@ -330,7 +330,7 @@ public class WebappActivity extends FullScreenActivity {

* @param orientation Default orientation for the activity.

public static void launchInstance(Context context, String id, String url, String icon,

- String title, int orientation) {

+ String title, int orientation, int source) {

String activityName = WebappActivity.class.getName();

if (!FeatureUtilities.isDocumentModeEligible(context)) {

// Specifically assign the app to a particular WebappActivity instance.

@@ -346,6 +346,7 @@ public class WebappActivity extends FullScreenActivity {

webappIntent.putExtra(ShortcutHelper.EXTRA_URL, url);

webappIntent.putExtra(ShortcutHelper.EXTRA_TITLE, title);

webappIntent.putExtra(ShortcutHelper.EXTRA_ORIENTATION, orientation);

+ webappIntent.putExtra(ShortcutHelper.EXTRA_SOURCE, source);

// On L, firing intents with the exact same data should relaunch a particular Activity.

webappIntent.setAction(Intent.ACTION_VIEW);