chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java - Issue 1220813010: Add UMA metrics to track the source of homescreen icons on launch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java

Issue 1220813010: Add UMA metrics to track the source of homescreen icons on launch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing reviewer comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java ('k') | chrome/browser/android/banners/app_banner_infobar_delegate_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java

index 60e4b264cfcf7c9b493ef6f6eea6ec23f0353f18..38e90855a2ab8d3c86c0834f65aab5726afbcd07 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java

@@ -7,6 +7,7 @@ package org.chromium.chrome.browser.webapps;

import android.test.suitebuilder.annotation.MediumTest;

import org.chromium.base.test.util.Feature;

+import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.ssl.ConnectionSecurityLevel;

import org.chromium.content_public.common.ScreenOrientationValues;

@@ -18,8 +19,8 @@ public class WebappVisibilityTest extends WebappActivityTestBase {

@Feature({"Webapps"})

public void testShouldShowTopControls() {

final String webappUrl = "http://originalwebsite.com";

- WebappInfo mockInfo = WebappInfo.create(

- WEBAPP_ID, webappUrl, null, null, ScreenOrientationValues.DEFAULT);

+ WebappInfo mockInfo = WebappInfo.create(WEBAPP_ID, webappUrl,

+ null, null, ScreenOrientationValues.DEFAULT, ShortcutHelper.SOURCE_UNKNOWN);

getActivity().getWebappInfo().copy(mockInfo);

// Show top controls for out-of-domain URLs.