chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java - Issue 1220813010: Add UMA metrics to track the source of homescreen icons on launch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java

Issue 1220813010: Add UMA metrics to track the source of homescreen icons on launch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding missing SOURCE gets and puts Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java » ('j') | chrome/browser/android/shortcut_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java

index 4afa08c0a86bf456dfe157086f8ee355bf59c6b4..ecc534f938b70f79ec17fc602e787b57ae814651 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java

@@ -23,7 +23,8 @@ public class WebappInfoTest extends InstrumentationTestCase {

String title = "webapp title";

String url = "about:blank";

- WebappInfo info = WebappInfo.create(id, url, null, title, ScreenOrientationValues.DEFAULT);

+ WebappInfo info = WebappInfo.create(id, url,

+ null, title, ScreenOrientationValues.DEFAULT, ShortcutHelper.SOURCE_UNKNOWN);

assertNotNull(info);

}

@@ -34,7 +35,8 @@ public class WebappInfoTest extends InstrumentationTestCase {

String title = "webapp title";

String url = "http://google.com";

- WebappInfo info = WebappInfo.create(id, url, null, title, ScreenOrientationValues.DEFAULT);

+ WebappInfo info = WebappInfo.create(id, url,

+ null, title, ScreenOrientationValues.DEFAULT, ShortcutHelper.SOURCE_UNKNOWN);

assertNotNull(info);

}