Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: chrome/browser/android/shortcut_info.h

Issue 1220813010: Add UMA metrics to track the source of homescreen icons on launch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/android/shortcut_helper.cc ('k') | chrome/browser/android/shortcut_info.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_ 5 #ifndef CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_
6 #define CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_ 6 #define CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_
7 7
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "content/public/common/manifest.h" 9 #include "content/public/common/manifest.h"
10 #include "third_party/WebKit/public/platform/modules/screen_orientation/WebScree nOrientationLockType.h" 10 #include "third_party/WebKit/public/platform/modules/screen_orientation/WebScree nOrientationLockType.h"
11 #include "url/gurl.h" 11 #include "url/gurl.h"
12 12
13 // Information needed to create a shortcut via ShortcutHelper. 13 // Information needed to create a shortcut via ShortcutHelper.
14 struct ShortcutInfo { 14 struct ShortcutInfo {
15
16 // This enum is used to back a UMA histogram, and must be treated as
17 // append-only.
18 enum Source {
19 SOURCE_UNKNOWN = 0,
20 SOURCE_ADD_TO_HOMESCREEN = 1,
21 SOURCE_APP_BANNER = 2,
22 SOURCE_COUNT = 3
23 };
24
15 ShortcutInfo(); 25 ShortcutInfo();
16 explicit ShortcutInfo(const GURL& shortcut_url); 26 explicit ShortcutInfo(const GURL& shortcut_url);
17 27
18 // Updates the info based on the given |manifest|. 28 // Updates the info based on the given |manifest|.
19 void UpdateFromManifest(const content::Manifest& manifest); 29 void UpdateFromManifest(const content::Manifest& manifest);
20 30
31 // Updates the source of the shortcut.
32 void UpdateSource(const Source source);
33
21 GURL url; 34 GURL url;
22 base::string16 title; 35 base::string16 title;
23 content::Manifest::DisplayMode display; 36 content::Manifest::DisplayMode display;
24 blink::WebScreenOrientationLockType orientation; 37 blink::WebScreenOrientationLockType orientation;
38 Source source;
25 }; 39 };
26 40
27 #endif // CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_ 41 #endif // CHROME_BROWSER_ANDROID_SHORTCUT_INFO_H_
OLDNEW
« no previous file with comments | « chrome/browser/android/shortcut_helper.cc ('k') | chrome/browser/android/shortcut_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698