Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: chrome/browser/android/shortcut_info.cc

Issue 1220813010: Add UMA metrics to track the source of homescreen icons on launch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding missing SOURCE gets and puts Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/shortcut_info.h" 5 #include "chrome/browser/android/shortcut_info.h"
6 6
7 ShortcutInfo::ShortcutInfo() 7 ShortcutInfo::ShortcutInfo()
8 : display(content::Manifest::DISPLAY_MODE_BROWSER), 8 : display(content::Manifest::DISPLAY_MODE_BROWSER),
9 orientation(blink::WebScreenOrientationLockDefault) { 9 orientation(blink::WebScreenOrientationLockDefault),
10 source(SOURCE_ADD_TO_HOMESCREEN) {
10 } 11 }
11 12
12 ShortcutInfo::ShortcutInfo(const GURL& shortcut_url) 13 ShortcutInfo::ShortcutInfo(const GURL& shortcut_url)
13 : url(shortcut_url), 14 : url(shortcut_url),
14 display(content::Manifest::DISPLAY_MODE_BROWSER), 15 display(content::Manifest::DISPLAY_MODE_BROWSER),
15 orientation(blink::WebScreenOrientationLockDefault) { 16 orientation(blink::WebScreenOrientationLockDefault),
17 source(SOURCE_ADD_TO_HOMESCREEN) {
16 } 18 }
17 19
18 void ShortcutInfo::UpdateFromManifest(const content::Manifest& manifest) { 20 void ShortcutInfo::UpdateFromManifest(const content::Manifest& manifest) {
19 if (!manifest.short_name.is_null()) 21 if (!manifest.short_name.is_null())
20 title = manifest.short_name.string(); 22 title = manifest.short_name.string();
21 else if (!manifest.name.is_null()) 23 else if (!manifest.name.is_null())
22 title = manifest.name.string(); 24 title = manifest.name.string();
23 25
24 // Set the url based on the manifest value, if any. 26 // Set the url based on the manifest value, if any.
25 if (manifest.start_url.is_valid()) 27 if (manifest.start_url.is_valid())
(...skipping 12 matching lines...) Expand all
38 40
39 // Set the orientation based on the manifest value, if any. 41 // Set the orientation based on the manifest value, if any.
40 if (manifest.orientation != blink::WebScreenOrientationLockDefault) { 42 if (manifest.orientation != blink::WebScreenOrientationLockDefault) {
41 // Ignore the orientation if the display mode is different from 43 // Ignore the orientation if the display mode is different from
42 // 'standalone'. 44 // 'standalone'.
43 // TODO(mlamouri): send a message to the developer console about this. 45 // TODO(mlamouri): send a message to the developer console about this.
44 if (display == content::Manifest::DISPLAY_MODE_STANDALONE) 46 if (display == content::Manifest::DISPLAY_MODE_STANDALONE)
45 orientation = manifest.orientation; 47 orientation = manifest.orientation;
46 } 48 }
47 } 49 }
50
51 void ShortcutInfo::UpdateSource(const Source new_source) {
52 source = new_source;
53 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698