Chromium Code Reviews Chromium Code Reviews
Issue 1220813003:
Fix flakiness and re-enable FormAutocompleteTest (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/renderer/autofill/form_autocomplete_browsertest.cc |
| diff --git a/chrome/renderer/autofill/form_autocomplete_browsertest.cc b/chrome/renderer/autofill/form_autocomplete_browsertest.cc |
| index ec161322f24255b021d2add576679f7cf553c88b..251d9d7c13b086724aeef859b1d9d388ea9a54f5 100644 |
| --- a/chrome/renderer/autofill/form_autocomplete_browsertest.cc |
| +++ b/chrome/renderer/autofill/form_autocomplete_browsertest.cc |
| @@ -69,7 +69,7 @@ void VerifyReceivedRendererMessages(content::MockRenderThread* render_thread, |
| // Tests that submitting a form generates WillSubmitForm and FormSubmitted |
| // messages with the form fields. |
| // Flaky: http://crbug.com/500851. |
|
Nico
2015/07/09 01:27:02
Remove this comment? Also below.
|
| -TEST_F(FormAutocompleteTest, DISABLED_NormalFormSubmit) { |
| +TEST_F(FormAutocompleteTest, NormalFormSubmit) { |
| // Load a form. |
| LoadHTML("<html><form id='myForm'><input name='fname' value='Rick'/>" |
| "<input name='lname' value='Deckard'/></form></html>"); |
| @@ -105,7 +105,7 @@ TEST_F(FormAutocompleteTest, SubmitEventPrevented) { |
| // Tests that submitting a form that has autocomplete="off" generates |
| // WillSubmitForm and FormSubmitted messages. |
| // Flaky: http://crbug.com/500851. |
| -TEST_F(FormAutocompleteTest, DISABLED_AutoCompleteOffFormSubmit) { |
| +TEST_F(FormAutocompleteTest, AutoCompleteOffFormSubmit) { |
| // Load a form. |
| LoadHTML("<html><form id='myForm' autocomplete='off'>" |
| "<input name='fname' value='Rick'/>" |
| @@ -122,7 +122,7 @@ TEST_F(FormAutocompleteTest, DISABLED_AutoCompleteOffFormSubmit) { |
| // Tests that fields with autocomplete off are submitted. |
| // Flaky: http://crbug.com/500851. |
| -TEST_F(FormAutocompleteTest, DISABLED_AutoCompleteOffInputSubmit) { |
| +TEST_F(FormAutocompleteTest, AutoCompleteOffInputSubmit) { |
| // Load a form. |
| LoadHTML("<html><form id='myForm'>" |
| "<input name='fname' value='Rick'/>" |
| @@ -141,7 +141,7 @@ TEST_F(FormAutocompleteTest, DISABLED_AutoCompleteOffInputSubmit) { |
| // off generates WillSubmitForm and FormSubmitted messages. |
| // Note: We previously did the opposite, for bug http://crbug.com/36520 |
| // Flaky: http://crbug.com/500851. |
| -TEST_F(FormAutocompleteTest, DISABLED_DynamicAutoCompleteOffFormSubmit) { |
| +TEST_F(FormAutocompleteTest, DynamicAutoCompleteOffFormSubmit) { |
| LoadHTML("<html><form id='myForm'><input name='fname' value='Rick'/>" |
| "<input name='lname' value='Deckard'/></form></html>"); |
