Issue 12208125: Remove extra space in open dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12208125: Remove extra space in open dialog. (Closed)

Created:
7 years, 10 months ago by mtomasz

Modified:
7 years, 10 months ago

Reviewers:
kinaba

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove extra space in open dialog. That space is only used in maximized mode of Files.app. When the extension acts as an open dialog, then there is no need for this space. Along the way, increased the space in Files.app mode to look better. TEST=Open a browser, press ctrl-o. Verify that there is no extra space like on the screenshot in the bug's description. BUG=175666 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181879

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	chrome/browser/resources/file_manager/css/file_manager.css	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

7 years, 10 months ago (2013-02-12 05:47:44 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12208125/1

Expand Messages | Collapse Messages