Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 12208123: [cc] Only NOW-binned tiles should contribute to over-memory accounting (Closed)

Created:
7 years, 10 months ago by nduca
Modified:
7 years, 10 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

[cc] Only NOW-binned tiles should contribute to over-memory accounting R=reveman,ccameron BUG=174572 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181988

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M cc/tile_manager.cc View 1 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nduca
7 years, 10 months ago (2013-02-12 05:23:55 UTC) #1
reveman
lgtm https://codereview.chromium.org/12208123/diff/1/cc/tile_manager.cc File cc/tile_manager.cc (right): https://codereview.chromium.org/12208123/diff/1/cc/tile_manager.cc#newcode529 cc/tile_manager.cc:529: ever_exceeded_memory_budget_ |= bytes_that_exceeded_memory_budget_in_now_bin > 0; nit: long line
7 years, 10 months ago (2013-02-12 06:30:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12208123/5001
7 years, 10 months ago (2013-02-12 06:48:49 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98566
7 years, 10 months ago (2013-02-12 07:59:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12208123/5001
7 years, 10 months ago (2013-02-12 08:06:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98594
7 years, 10 months ago (2013-02-12 09:01:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12208123/5001
7 years, 10 months ago (2013-02-12 18:19:39 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 20:03:20 UTC) #8
Message was sent while issue was closed.
Change committed as 181988

Powered by Google App Engine
This is Rietveld 408576698