Issue 12208122: Fixed volume icons' alignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12208122: Fixed volume icons' alignment. (Closed)

Created:
7 years, 10 months ago by mtomasz

Modified:
7 years, 10 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed volume icons' alignment. New icons are smaller and do not look good with vertical centering. This patch aligns them to the label's baseline and also adds small margin between icons and labels. TEST=Enter Files.app and check icons in the left nav. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181844

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/resources/file_manager/css/file_manager.css	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mtomasz

yoshiki: PTAL at this trivial change. Josh approved this ui change.

7 years, 10 months ago (2013-02-12 02:54:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12208122/1

7 years, 10 months ago (2013-02-12 03:17:51 UTC) #3

commit-bot: I haz the power

7 years, 10 months ago (2013-02-12 04:21:44 UTC) #4

Retried try job too often on mac_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Expand Messages | Collapse Messages