Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 12208118: Add support for ordinal scroll amounts (Closed)

Created:
7 years, 10 months ago by DaveMoore
Modified:
7 years, 10 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Add support for ordinal scroll amounts BUG=175604 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181951

Patch Set 1 #

Patch Set 2 : Fix test compile failures #

Patch Set 3 : Fix widget_unittest compile failure #

Patch Set 4 : Fix interactive_ui_tests failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -40 lines) Patch
M chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 1 chunk +14 lines, -2 lines 0 comments Download
M ui/aura/test/event_generator.cc View 1 6 chunks +12 lines, -12 lines 0 comments Download
M ui/base/events/event.h View 3 chunks +11 lines, -0 lines 0 comments Download
M ui/base/events/event.cc View 3 chunks +14 lines, -5 lines 0 comments Download
M ui/base/events/event_utils.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/base/win/events_win.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/base/x/events_x.cc View 1 2 3 13 chunks +61 lines, -14 lines 0 comments Download
M ui/base/x/x11_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
DaveMoore
7 years, 10 months ago (2013-02-12 00:30:43 UTC) #1
sadrul
LGTM There is ongoing discussions on making the commit logs better explain the change: perhaps ...
7 years, 10 months ago (2013-02-12 16:03:11 UTC) #2
sky
7 years, 10 months ago (2013-02-12 18:03:57 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698