Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: pkg/scheduled_test/lib/scheduled_test.dart

Issue 12208116: Roll back r18349. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/scheduled_test/lib/src/schedule.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/scheduled_test/lib/scheduled_test.dart
diff --git a/pkg/scheduled_test/lib/scheduled_test.dart b/pkg/scheduled_test/lib/scheduled_test.dart
index 26a67323278590255e5277095d9d2c0123e47fdf..23a060ff052cfc5764980f6603abda3411a80eaa 100644
--- a/pkg/scheduled_test/lib/scheduled_test.dart
+++ b/pkg/scheduled_test/lib/scheduled_test.dart
@@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+// TODO(nweiz): Keep track of and display multiple errors so there's more
+// visibility into cascading errors.
// TODO(nweiz): Add timeouts to scheduled tests.
// TODO(nweiz): Add support for calling [schedule] while the schedule is already
// running.
@@ -192,9 +194,7 @@ void _test(String description, void body(), Function testFn) {
asyncDone();
}).catchError((e) {
if (e is ScheduleError) {
- assert(e.schedule.errors.contains(e));
- assert(e.schedule == currentSchedule);
- unittest.registerException(e.schedule.errorString());
+ unittest.registerException(new ExpectException(e.toString()));
} else if (e is AsyncError) {
unittest.registerException(e.error, e.stackTrace);
} else {
« no previous file with comments | « no previous file | pkg/scheduled_test/lib/src/schedule.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698