Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 12208099: Create java AwBrowserContext (Closed)

Created:
7 years, 10 months ago by joth
Modified:
7 years, 10 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Create java AwBrowserContext This will allow all the singleton object (geolocation, cookie manager etc) instances to be collected together by their logical association. BUG= Superseded by https://codereview.chromium.org/12313055/

Patch Set 1 #

Total comments: 4

Patch Set 2 : ben comments #

Patch Set 3 : remove unneeded edit #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -3 lines) Patch
A android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java View 1 2 3 1 chunk +50 lines, -0 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java View 1 2 3 4 chunks +19 lines, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 2 3 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
joth
7 years, 10 months ago (2013-02-09 02:35:02 UTC) #1
benm (inactive)
https://codereview.chromium.org/12208099/diff/1/android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java File android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java (right): https://codereview.chromium.org/12208099/diff/1/android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java#newcode1 android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java:1: // Copyright (c) 2012 The Chromium Authors. All rights ...
7 years, 10 months ago (2013-02-11 11:47:32 UTC) #2
joth
https://codereview.chromium.org/12208099/diff/1/android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java File android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java (right): https://codereview.chromium.org/12208099/diff/1/android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java#newcode1 android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java:1: // Copyright (c) 2012 The Chromium Authors. All rights ...
7 years, 10 months ago (2013-02-20 03:51:14 UTC) #3
benm (inactive)
lgtm
7 years, 10 months ago (2013-02-20 12:27:32 UTC) #4
benm (inactive)
7 years, 10 months ago (2013-02-25 12:27:08 UTC) #5
We can close this now Kristian has taken over in
https://codereview.chromium.org/12313055/ ?

Powered by Google App Engine
This is Rietveld 408576698