chrome/service/cloud_print/cloud_print_wipeout.cc - Issue 12208089: Changing CloudPrintURLFetcher instantiation to be more testable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/cloud_print_wipeout.cc

Issue 12208089: Changing CloudPrintURLFetcher instantiation to be more testable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated Gene's suggestions Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/service/cloud_print/cloud_print_wipeout.cc

diff --git a/chrome/service/cloud_print/cloud_print_wipeout.cc b/chrome/service/cloud_print/cloud_print_wipeout.cc

index a6be0ef02c21bda5cad7ebecd53bb1c1712b6afd..38deaccfef2409529e511184b1742a1c3e08d3aa 100644

--- a/chrome/service/cloud_print/cloud_print_wipeout.cc

+++ b/chrome/service/cloud_print/cloud_print_wipeout.cc

@@ -38,7 +38,7 @@ void CloudPrintWipeout::UnregisterNextPrinter() {

GURL url = GetUrlForPrinterDelete(cloud_print_server_url_,

printer_id,

"connector_disabled");

- request_ = new CloudPrintURLFetcher;

+ request_ = CloudPrintURLFetcher::Create();

request_->StartGetRequest(url, this, kMaxWipeoutAttempts, std::string());

}

« no previous file with comments | « chrome/service/cloud_print/cloud_print_url_fetcher.cc ('k') | chrome/service/cloud_print/job_status_updater.cc » ('j') | no next file with comments »