chrome/service/cloud_print/cloud_print_auth.cc - Issue 12208089: Changing CloudPrintURLFetcher instantiation to be more testable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/cloud_print_auth.cc

Issue 12208089: Changing CloudPrintURLFetcher instantiation to be more testable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated Gene's suggestions Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/service/cloud_print/cloud_print_auth.cc

diff --git a/chrome/service/cloud_print/cloud_print_auth.cc b/chrome/service/cloud_print/cloud_print_auth.cc

index 6c273bb920bef5b220f68c0061d96c3bd1057764..ae35ccb040ca67c7712ab97b3f905e9a2389f8fb 100644

--- a/chrome/service/cloud_print/cloud_print_auth.cc

+++ b/chrome/service/cloud_print/cloud_print_auth.cc

@@ -70,7 +70,7 @@ void CloudPrintAuth::AuthenticateWithToken(

GURL get_authcode_url = GetUrlForGetAuthCode(cloud_print_server_url_,

oauth_client_info_.client_id,

proxy_id_);

- request_ = new CloudPrintURLFetcher;

+ request_ = CloudPrintURLFetcher::Create();

request_->StartGetRequest(get_authcode_url,

this,

kCloudPrintAuthMaxRetryCount,

« no previous file with comments | « no previous file | chrome/service/cloud_print/cloud_print_connector.cc » ('j') | no next file with comments »