chrome/service/cloud_print/job_status_updater.cc - Issue 12208089: Changing CloudPrintURLFetcher instantiation to be more testable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/job_status_updater.cc

Issue 12208089: Changing CloudPrintURLFetcher instantiation to be more testable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Modified change to use static factory pattern Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/service/cloud_print/cloud_print_url_fetcher.cc ('K') | « chrome/service/cloud_print/cloud_print_url_fetcher.cc ('k') | chrome/service/cloud_print/printer_job_handler.cc » ('j') | chrome/service/cloud_print/printer_job_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/service/cloud_print/job_status_updater.cc

diff --git a/chrome/service/cloud_print/job_status_updater.cc b/chrome/service/cloud_print/job_status_updater.cc

index d28ae1fbe4a2fd01b7b2068a6ff3143ad5dc6d6e..4b602113f79e6bee7b3d57cbc16aa6516dd1e021 100644

--- a/chrome/service/cloud_print/job_status_updater.cc

+++ b/chrome/service/cloud_print/job_status_updater.cc

@@ -58,7 +58,7 @@ void JobStatusUpdater::UpdateStatus() {

}

if (need_update) {

- request_ = new CloudPrintURLFetcher;

+ request_ = CloudPrintURLFetcher::Create();

request_->StartGetRequest(

GetUrlForJobStatusUpdate(

cloud_print_server_url_, job_id_, last_job_details_),