Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 12208084: Removed a context menu from Files.app's left nav, since it became redundant. (Closed)

Created:
7 years, 10 months ago by mtomasz
Modified:
7 years, 10 months ago
Reviewers:
yoshiki, Haruki Sato
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Removed a context menu from Files.app's left nav, since it became redundant. This menu became redundant after moving the remaining space indicator to the gear button menu. TEST=Check if Files.app is not broken. Context menu should be also gone. BUG=174622 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181858

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -86 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 2 3 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 3 chunks +1 line, -47 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager_commands.js View 1 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/resources/file_manager/main.html View 1 3 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtomasz
@yoshiki: PTAL. Sorry for so many CR recently.
7 years, 10 months ago (2013-02-08 07:36:01 UTC) #1
yoshiki
+haruki. LGTM but please wait for haruki's approval, since the context menu was introduced by ...
7 years, 10 months ago (2013-02-08 07:45:16 UTC) #2
Haruki Sato
lgtm just a comment about remaining code piece. Thank you for taking this! https://codereview.chromium.org/12208084/diff/1/chrome/browser/resources/file_manager/js/file_manager_commands.js File ...
7 years, 10 months ago (2013-02-08 08:56:00 UTC) #3
mtomasz
https://codereview.chromium.org/12208084/diff/1/chrome/browser/resources/file_manager/js/file_manager_commands.js File chrome/browser/resources/file_manager/js/file_manager_commands.js (left): https://codereview.chromium.org/12208084/diff/1/chrome/browser/resources/file_manager/js/file_manager_commands.js#oldcode398 chrome/browser/resources/file_manager/js/file_manager_commands.js:398: window.open(FileManager.FILES_APP_HELP, 'help'); On 2013/02/08 08:56:00, Haruki Sato wrote: > ...
7 years, 10 months ago (2013-02-08 10:08:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12208084/1
7 years, 10 months ago (2013-02-08 11:09:34 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=82561
7 years, 10 months ago (2013-02-08 13:50:47 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 00:59:20 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698