Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12208057: Add explicit base to FilePath. (Closed)

Created:
7 years, 10 months ago by brettw
Modified:
7 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, cbentzel+watch_chromium.org, vsevik, jam, sail+watch_chromium.org, joi+watch-content_chromium.org, yurys, darin-cc_chromium.org, apatrick_chromium, pfeldman, jochen+watch_chromium.org
Visibility:
Public.

Description

Add explicit base to FilePath. This changes the "easy" content subdirectories (everything but browser, renderer, and common) and the ppapi top level directory. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -201 lines) Patch
M content/app/content_main_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_info_collector_linux.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/gpu/gpu_info_collector_win.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/plugin/plugin_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/plugin_thread.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/broker_process_dispatcher.h View 1 chunk +11 lines, -11 lines 0 comments Download
M content/ppapi_plugin/broker_process_dispatcher.cc View 11 chunks +16 lines, -15 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/android/browsertests_apk/content_browser_tests_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/paths_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/paths_mac.mm View 3 chunks +6 lines, -5 lines 0 comments Download
M content/shell/shell_browser_context.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/shell/shell_browser_context.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/shell/shell_browser_main.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/shell/shell_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_content_browser_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/shell_devtools_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_devtools_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/shell_download_manager_delegate.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/shell/shell_download_manager_delegate.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M content/shell/shell_main_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/shell_message_filter.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/shell/shell_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/shell_messages.h View 4 chunks +4 lines, -4 lines 0 comments Download
M content/shell/shell_network_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_render_process_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/shell_render_process_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_url_request_context_getter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/shell_url_request_context_getter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/webkit_test_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/shell/webkit_test_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/webkit_test_platform_support_linux.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/webkit_test_runner.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/shell/webkit_test_runner.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M content/test/content_browser_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/content_browser_test_utils.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/content_test_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_test_expectations_parser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_test_expectations_parser.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/test/layout_browsertest.h View 3 chunks +10 lines, -10 lines 0 comments Download
M content/test/layout_browsertest.cc View 4 chunks +12 lines, -9 lines 0 comments Download
M content/test/layout_test_http_server.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/layout_test_http_server.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/test/net/url_request_mock_http_job.cc View 10 chunks +13 lines, -12 lines 0 comments Download
M content/test/net/url_request_prepackaged_interceptor.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/test/test_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_content_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/webrtc_audio_device_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/webrtc_audio_device_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 6 chunks +7 lines, -7 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/dir_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/file_path.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
TBR=jam
7 years, 10 months ago (2013-02-07 00:21:24 UTC) #1
jam
7 years, 10 months ago (2013-02-07 21:58:57 UTC) #2
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698