Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3183)

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 12208040: [win] Add a progress bar in the app launcher for app installs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: respond to comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
index f585ed2f5ce311505f4a2167ba5257b9e08434be..96d6ffe99e9354fedbfa491cc46efb813a2fbd29 100644
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
@@ -468,8 +468,10 @@ void CompleteInstallFunction::OnGetAppLauncherEnabled(
bool app_launcher_enabled) {
if (app_launcher_enabled) {
std::string name;
- DCHECK(approval_->parsed_manifest->GetString(extension_manifest_keys::kName,
- &name));
+ if (!approval_->parsed_manifest->GetString(extension_manifest_keys::kName,
+ &name)) {
+ NOTREACHED();
benwells 2013/02/06 21:54:44 Not: indenting of line 472
koz (OOO until 15th September) 2013/02/07 03:13:23 Done.
+ }
// Tell the app list about the install that we just started.
chrome::NotifyAppListOfBeginExtensionInstall(
profile(), id, name, approval_->installing_icon);
@@ -511,6 +513,12 @@ void CompleteInstallFunction::OnExtensionInstallFailure(
Release();
}
+void CompleteInstallFunction::OnExtensionDownloadProgress(
+ const std::string& id,
+ content::DownloadItem* item) {
+ chrome::NotifyAppListOfDownloadProgress(profile(), id,
+ item->PercentComplete());
+}
bool GetBrowserLoginFunction::RunImpl() {
SetResult(CreateLoginResult(profile_->GetOriginalProfile()));

Powered by Google App Engine
This is Rietveld 408576698