Issue 12208011: Add separate flag for --trace-stub-failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12208011: Add separate flag for --trace-stub-failures (Closed)

Created:
7 years, 10 months ago by danno

Modified:
7 years, 10 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add separate flag for --trace-stub-failures R=svenpanne@chromium.org

Patch Set 2 : Remove MIPS changes #

Total comments: 1

Patch Set 3 : Review feedback #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -95 lines)			Patch
M	src/arm/deoptimizer-arm.cc	View		18 chunks	+18 lines, -18 lines	0 comments	Download
M	src/deoptimizer.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	src/deoptimizer.cc	View	1 2	20 chunks	+30 lines, -25 lines	0 comments	Download
M	src/flag-definitions.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/ia32/deoptimizer-ia32.cc	View		25 chunks	+25 lines, -25 lines	0 comments	Download
M	src/x64/deoptimizer-x64.cc	View		25 chunks	+25 lines, -25 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with a nit https://codereview.chromium.org/12208011/diff/1008/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/12208011/diff/1008/src/deoptimizer.cc#newcode501 src/deoptimizer.cc:501: (FLAG_trace_stub_failures && frame_type == StackFrame::STUB); ...

7 years, 10 months ago (2013-02-05 13:03:11 UTC) #2

Feedback addressed, landed.