Adding device selection menus to the content setting bubble

chrome/browser/ui/content_settings/content_setting_media_menu_model.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_CONTENT_SETTINGS_CONTENT_SETTING_MEDIA_MENU_MODEL_H_
+#define CHROME_BROWSER_UI_CONTENT_SETTINGS_CONTENT_SETTING_MEDIA_MENU_MODEL_H_
+
+#include <map>
+
+#include "base/callback.h"
+#include "content/public/common/media_stream_request.h"
+#include "ui/base/models/simple_menu_model.h"
+
+class ContentSettingBubbleModel;
+class PrefService;
+
+// A menu model that builds the contents of the media capture devices menu in
+// the content setting bubble.
+class ContentSettingMediaMenuModel : public ui::SimpleMenuModel,
+                                     public ui::SimpleMenuModel::Delegate {
+ public:
+  // Callback to update the label of the menu in the UI.
+  typedef base::Callback<void(content::MediaStreamType, const std::string&)>
+      MenuLabelChangedCallback;
+
+  ContentSettingMediaMenuModel(
+      PrefService* prefs,
+      content::MediaStreamType type,
+      ContentSettingBubbleModel* bubble_model,
+      const MenuLabelChangedCallback& callback);
+

[Peter Kasting, 2013/02/16 02:55:13]

Nit: Blank line probably not necessary

[no longer working on chromium, 2013/02/18 17:20:04]

Done.

+  virtual ~ContentSettingMediaMenuModel();
+
+  // ui::SimpleMenuModel::Delegate implementation:

[Peter Kasting, 2013/02/16 02:55:13]

Nit: I suggest just "// ui::SimpleMenuModel::Delegate:" (slowly trying to
standardize on this form elsewhere)

[no longer working on chromium, 2013/02/18 17:20:04]

Done.

+  virtual bool IsCommandIdChecked(int command_id) const OVERRIDE;
+  virtual bool IsCommandIdEnabled(int command_id) const OVERRIDE;
+  virtual bool GetAcceleratorForCommandId(
+      int command_id,
+      ui::Accelerator* accelerator) OVERRIDE;
+  virtual void ExecuteCommand(int command_id) OVERRIDE;
+
+ private:
+  typedef std::map<int, content::MediaStreamDevice> CommandMap;
+
+  // Internal method to build the menu.

[Peter Kasting, 2013/02/16 02:55:13]

Nit: This comment adds nothing.

[no longer working on chromium, 2013/02/18 17:20:04]

Removed.

+  void BuildMenu();
+
+  PrefService* prefs_;  // Weak.
+  content::MediaStreamType type_;
+  ContentSettingBubbleModel* media_bubble_model_;  // Weak.
+  MenuLabelChangedCallback callback_;
+
+  // Map of command IDs to devices.

[Peter Kasting, 2013/02/16 02:55:13]

Nit: This comment also adds very little.

[no longer working on chromium, 2013/02/18 17:20:04]

Removed.

+  CommandMap commands_;
+
+  DISALLOW_COPY_AND_ASSIGN(ContentSettingMediaMenuModel);
+};
+
+#endif  // CHROME_BROWSER_UI_CONTENT_SETTINGS_CONTENT_SETTING_MEDIA_MENU_MODEL_H_