Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7307)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/test_presubmit.py

Issue 1220793010: [ui/base;css] adding string template expression replacement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review changes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/resources/ntp4/new_tab_theme.css ('K') | « chrome/browser/resources/ntp4/new_tab_theme.css ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/test_presubmit.py
diff --git a/chrome/browser/test_presubmit.py b/chrome/browser/test_presubmit.py
index 1ad8ed270150efdac5a88b9df39163512ab964c5..c4293defacf9b4d257013ab5bcf4b477d7879cba 100755
--- a/chrome/browser/test_presubmit.py
+++ b/chrome/browser/test_presubmit.py
@@ -762,6 +762,10 @@ blah /* hey! */
100% { height: 500px; }
}
+#rule { /* ${TemplateExpressions} should be ignored. */
+ rule: ${someValue};
+}
+
#rule {
rule: value; }""", """
- Always put a rule closing brace (}) on a new line.
« chrome/browser/resources/ntp4/new_tab_theme.css ('K') | « chrome/browser/resources/ntp4/new_tab_theme.css ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698