Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4257)

Unified Diff: chrome/browser/test_presubmit.py

Issue 1220793010: [ui/base;css] adding string template expression replacement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: better use of StringPiece in template expressions Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/test_presubmit.py
diff --git a/chrome/browser/test_presubmit.py b/chrome/browser/test_presubmit.py
index 1ad8ed270150efdac5a88b9df39163512ab964c5..68ec8efbbafa7004f21a13f6511aa51de317607f 100755
--- a/chrome/browser/test_presubmit.py
+++ b/chrome/browser/test_presubmit.py
@@ -49,6 +49,15 @@ class HtmlStyleTest(SuperMoxTestBase):
error = checker(1, line)
self.assertEqual('', error, 'Should not be flagged as style error: ' + line)
+ def testTemplateExpressionRemoval(self):
+ lines = [
+ '${tag}',
+ '$${}',
+ '<hr class="${tag}">',
+ ]
+ for line in lines:
+ self.ShouldPassCheck(line, self.checker.ClassesUseDashFormCheck)
+
def testClassesUseDashFormCheckFails(self):
lines = [
' <a class="Foo-bar" href="classBar"> ',

Powered by Google App Engine
This is Rietveld 408576698