Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: ui/base/template_expressions_unittest.cc

Issue 1220793010: [ui/base;css] adding string template expression replacement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge with master Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/template_expressions.cc ('k') | ui/base/ui_base.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/template_expressions_unittest.cc
diff --git a/ui/base/template_expressions_unittest.cc b/ui/base/template_expressions_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..77d46e797c837820d07b9c606bf73b0dce39baea
--- /dev/null
+++ b/ui/base/template_expressions_unittest.cc
@@ -0,0 +1,42 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
Dan Beam 2015/07/15 18:56:41 nit: 2015
dschuyler 2015/07/15 21:40:44 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ui/base/template_expressions.h"
+
+#include "base/strings/utf_string_conversions.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace ui {
+
+TEST(TemplateExpressionsTest, ReplaceTemplateExpressionsPieces) {
+ std::map<base::StringPiece, std::string> substitutions;
+ substitutions["test"] = "word";
+ substitutions["5"] = "number";
+ substitutions[""] = "blank";
+
+ EXPECT_EQ(ReplaceTemplateExpressions("${ab${cd}ef}", substitutions), "ef}");
+ EXPECT_EQ(ReplaceTemplateExpressions("${}", substitutions), "blank");
+ EXPECT_EQ(ReplaceTemplateExpressions("", substitutions), "");
+ EXPECT_EQ(ReplaceTemplateExpressions("${test}", substitutions), "word");
+ EXPECT_EQ(ReplaceTemplateExpressions("${5} ", substitutions), "number ");
+ EXPECT_EQ(
+ ReplaceTemplateExpressions("multiple: ${test}, ${5}.", substitutions),
+ "multiple: word, number.");
+}
+
+TEST(TemplateExpressionsTest,
+ ReplaceTemplateExpressionsConsecutiveDollarSignsPieces) {
+ std::map<base::StringPiece, std::string> substitutions;
+ substitutions["a"] = "9a";
+ substitutions["b"] = "8b";
+ substitutions["c"] = "7c";
Dan Beam 2015/07/15 18:56:41 nit: 9a 8b 7c -> x y z
dschuyler 2015/07/15 21:40:44 Done.
+ EXPECT_EQ(
+ ReplaceTemplateExpressions("$${a} $$${b} $$$${c} $$", substitutions),
Dan Beam 2015/07/15 18:56:41 nit: $$ first
dschuyler 2015/07/15 21:40:44 Based on our conversation, this is changing if we'
+ "${a} $${b} $$${c} $");
+ EXPECT_EQ(ReplaceTemplateExpressions("$12", substitutions), "12");
+ EXPECT_EQ(ReplaceTemplateExpressions("$$", substitutions), "$");
Dan Beam 2015/07/15 18:56:41 duplicative
dschuyler 2015/07/15 21:40:44 Done.
+ EXPECT_EQ(ReplaceTemplateExpressions("$", substitutions), "");
+}
+
+} // namespace ui
« no previous file with comments | « ui/base/template_expressions.cc ('k') | ui/base/ui_base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698