[ui/base;css] adding string template expression replacement

ui/base/template_expressions_unittest.cc

Index: ui/base/template_expressions_unittest.cc
diff --git a/ui/base/template_expressions_unittest.cc b/ui/base/template_expressions_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..28621af097fb3517e905f1e2484b4fc92c7c9bcf
--- /dev/null
+++ b/ui/base/template_expressions_unittest.cc
@@ -0,0 +1,94 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ui/base/template_expressions.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace ui {
+
+TEST(TemplateExpressionsTest, ReplaceTemplateExpressions) {
+  std::map<base::string16, base::string16> substitutions;
+  substitutions[base::ASCIIToUTF16("one")] = base::ASCIIToUTF16("9a");

[Dan Beam, 2015/07/14 17:14:35]

why are you using the version that requires this annoying base::ASCIIToUTF16()
in mah code?

[Dan Beam, 2015/07/14 17:14:35]

instead of building a map (which I have to do in my head) and replacing a ton of
things in a complex template (which I also have to attempt in my head), just do
one thing at a time, IMO

  std::map<base::string16, base::string16> substitutions;
  substitutions["one"] = "9a";
  EXPECT_STREQ(ReplaceTemplateExpressions("${one}"), "9a");

  ... more substitutions (if necessary) + EXPECTs ...

[dschuyler, 2015/07/14 21:05:31]

I'll work on this.

[dschuyler, 2015/07/14 21:05:31]

Done.

[dschuyler, 2015/07/15 18:47:04]

How about three entries?  I've changed the keys/values to be more clear.  And
I've separated the tests more.

Done.

+  substitutions[base::ASCIIToUTF16("b")] = base::ASCIIToUTF16("8b");
+  substitutions[base::ASCIIToUTF16("cc")] = base::ASCIIToUTF16("7c");
+  substitutions[base::ASCIIToUTF16("four")] = base::ASCIIToUTF16("6d");
+  substitutions[base::ASCIIToUTF16("very long with spaces")] =
+      base::ASCIIToUTF16("5e");
+  substitutions[base::ASCIIToUTF16("")] = base::ASCIIToUTF16("4f");
+  substitutions[base::ASCIIToUTF16("&")] = base::ASCIIToUTF16("3g");
+  substitutions[base::ASCIIToUTF16("$")] = base::ASCIIToUTF16("2h");
+  substitutions[base::ASCIIToUTF16("$$")] = base::ASCIIToUTF16("1i");
+
+  EXPECT_EQ(ReplaceTemplateExpressions(base::ASCIIToUTF16("${ab${cd}ef}"),

[Dan Beam, 2015/07/14 17:14:35]

EXPECT_STREQ

[dschuyler, 2015/07/14 21:05:30]

Done.

+                                       substitutions),
+            base::ASCIIToUTF16("ef}"));
+  EXPECT_EQ(
+      ReplaceTemplateExpressions(base::ASCIIToUTF16("${}"), substitutions),
+      base::ASCIIToUTF16("4f"));
+  EXPECT_EQ(ReplaceTemplateExpressions(base::ASCIIToUTF16(""), substitutions),
+            base::ASCIIToUTF16(""));
+  EXPECT_EQ(ReplaceTemplateExpressions(
+                base::ASCIIToUTF16(
+                    "${one}a,${b}b,${cc}c,${four}d,${very long with "
+                    "spaces}e,${}f,${&}g,${$}h,${$$}i"),
+                substitutions),
+            base::ASCIIToUTF16("9aa,8bb,7cc,6dd,5ee,4ff,3gg,2hh,1ii"));
+}
+
+TEST(TemplateExpressionsTest,
+     ReplaceTemplateExpressionsConsecutiveDollarSigns) {
+  std::map<base::string16, base::string16> substitutions;
+  substitutions[base::ASCIIToUTF16("a")] = base::ASCIIToUTF16("9a");
+  substitutions[base::ASCIIToUTF16("b")] = base::ASCIIToUTF16("8b");
+  substitutions[base::ASCIIToUTF16("c")] = base::ASCIIToUTF16("7c");
+  EXPECT_EQ(ReplaceTemplateExpressions(
+                base::ASCIIToUTF16("$${a} $$${b} $$$${c} $$"), substitutions),
+            base::ASCIIToUTF16("${a} $${b} $$${c} $"));
+  EXPECT_EQ(
+      ReplaceTemplateExpressions(base::ASCIIToUTF16("$12"), substitutions),
+      base::ASCIIToUTF16("12"));
+  EXPECT_EQ(ReplaceTemplateExpressions(base::ASCIIToUTF16("$$"), substitutions),
+            base::ASCIIToUTF16("$"));
+  EXPECT_EQ(ReplaceTemplateExpressions(base::ASCIIToUTF16("$"), substitutions),
+            base::ASCIIToUTF16(""));
+}
+
+TEST(TemplateExpressionsTest, ReplaceTemplateExpressionsPieces) {
+  std::map<base::StringPiece, std::string> substitutions;
+  substitutions["one"] = "9a";
+  substitutions["b"] = "8b";
+  substitutions["cc"] = "7c";
+  substitutions["four"] = "6d";
+  substitutions["very long with spaces"] = "5e";
+  substitutions[""] = "4f";
+  substitutions["&"] = "3g";
+  substitutions["$"] = "2h";
+  substitutions["$$"] = "1i";
+
+  EXPECT_EQ(ReplaceTemplateExpressions("${ab${cd}ef}", substitutions), "ef}");
+  EXPECT_EQ(ReplaceTemplateExpressions("${}", substitutions), "4f");
+  EXPECT_EQ(ReplaceTemplateExpressions("", substitutions), "");
+  EXPECT_EQ(ReplaceTemplateExpressions(
+                "${one}a,${b}b,${cc}c,${four}d,${very long with "
+                "spaces}e,${}f,${&}g,${$}h,${$$}i",
+                substitutions),
+            "9aa,8bb,7cc,6dd,5ee,4ff,3gg,2hh,1ii");
+}
+
+TEST(TemplateExpressionsTest,
+     ReplaceTemplateExpressionsConsecutiveDollarSignsPieces) {
+  std::map<base::StringPiece, std::string> substitutions;
+  substitutions["a"] = "9a";
+  substitutions["b"] = "8b";
+  substitutions["c"] = "7c";
+  EXPECT_EQ(
+      ReplaceTemplateExpressions("$${a} $$${b} $$$${c} $$", substitutions),
+      "${a} $${b} $$${c} $");
+  EXPECT_EQ(ReplaceTemplateExpressions("$12", substitutions), "12");
+  EXPECT_EQ(ReplaceTemplateExpressions("$$", substitutions), "$");
+  EXPECT_EQ(ReplaceTemplateExpressions("$", substitutions), "");
+}
+
+}  // namespace ui