Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2110)

Unified Diff: chrome/browser/web_dev_style/css_checker.py

Issue 1220793010: [ui/base;css] adding string template expression replacement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix for incognito window Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_dev_style/css_checker.py
diff --git a/chrome/browser/web_dev_style/css_checker.py b/chrome/browser/web_dev_style/css_checker.py
index 2c56fb6ecb8e4e75ac1ed68a7c71f898a55dc886..2b3d067adfe9107b776ef9769851b48d2756174b 100644
--- a/chrome/browser/web_dev_style/css_checker.py
+++ b/chrome/browser/web_dev_style/css_checker.py
@@ -29,7 +29,11 @@ class CSSChecker(object):
return s[0] == s[1] == s[2] if len(s) == 3 else s[0:2] == s[2:4] == s[4:6]
def _remove_all(s):
- return _remove_grit(_remove_ats(_remove_comments(s)))
+ s = _remove_grit(s);
Dan Beam 2015/07/14 17:14:35 this is python, no ;
dschuyler 2015/07/14 21:05:30 Done.
+ s = _remove_ats(s);
+ s = _remove_comments(s);
+ s = _remove_template_expressions(s);
+ return s;
def _remove_ats(s):
at_reg = re.compile(r"""
@@ -43,6 +47,9 @@ class CSSChecker(object):
def _remove_comments(s):
return re.sub(re.compile(r'/\*.*?\*/', re.DOTALL), '', s)
+ def _remove_template_expressions(s):
+ return re.sub(re.compile(r'\${[^}]*}', re.DOTALL), '', s)
+
def _remove_grit(s):
grit_reg = re.compile(r"""
<if[^>]+>.*?<\s*/\s*if[^>]*>| # <if> contents </if>

Powered by Google App Engine
This is Rietveld 408576698