[ui/base;css] adding string template expression replacement

chrome/browser/web_dev_style/css_checker.py

Index: chrome/browser/web_dev_style/css_checker.py
diff --git a/chrome/browser/web_dev_style/css_checker.py b/chrome/browser/web_dev_style/css_checker.py
index 2c56fb6ecb8e4e75ac1ed68a7c71f898a55dc886..9bddc60fb01f3a9b51a5f69bceca7b467289ecec 100644
--- a/chrome/browser/web_dev_style/css_checker.py
+++ b/chrome/browser/web_dev_style/css_checker.py
@@ -29,7 +29,8 @@ class CSSChecker(object):
       return s[0] == s[1] == s[2] if len(s) == 3 else s[0:2] == s[2:4] == s[4:6]
 
     def _remove_all(s):
-      return _remove_grit(_remove_ats(_remove_comments(s)))
+      return _remove_grit(_remove_ats(_remove_comments(
+          _remove_replacement_tags(s))))

[Dan Beam, 2015/07/09 19:26:01]

maybe it's time to do:

  tmp = s
  tmp = _remove_grit(tmp)
  tmp = _remove_ats(tmp)
  tmp = _remove_comments(tmp)
  tmp = _remove_template_expressions(tmp)
  return tmp

[dschuyler, 2015/07/14 00:56:17]

Done.

 
     def _remove_ats(s):
       at_reg = re.compile(r"""
@@ -43,6 +44,9 @@ class CSSChecker(object):
     def _remove_comments(s):
       return re.sub(re.compile(r'/\*.*?\*/', re.DOTALL), '', s)
 
+    def _remove_replacement_tags(s):

[Dan Beam, 2015/07/09 19:26:01]

nit: _remove_template_expressions

[dschuyler, 2015/07/14 00:56:17]

Done.

+      return re.sub(re.compile(r'\${[^}]*}', re.DOTALL), '', s)

[Dan Beam, 2015/07/09 19:26:01]

can haz test in chrome/browser/test_presubmit.py?

+
     def _remove_grit(s):
       grit_reg = re.compile(r"""
           <if[^>]+>.*?<\s*/\s*if[^>]*>|  # <if> contents </if>