[ui/base;css] adding string template expression replacement

chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/ntp_resource_cache.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 35 matching lines @@
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_process_host.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_urls.h"
 #include "grit/browser_resources.h"
 #include "grit/components_strings.h"
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
+#include "ui/base/template_expressions.h"
 #include "ui/base/theme_provider.h"
 #include "ui/base/webui/jstemplate_builder.h"
 #include "ui/base/webui/web_ui_util.h"
 #include "ui/gfx/animation/animation.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/gfx/sys_color_change_listener.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chromeos/chromeos_switches.h"
@@ skipping 473 matching lines @@
 
 void NTPResourceCache::CreateNewTabIncognitoCSS() {
   ui::ThemeProvider* tp = ThemeServiceFactory::GetForProfile(profile_);
   DCHECK(tp);
 
   // Get our theme colors
   SkColor color_background =
       GetThemeColor(tp, ThemeProperties::COLOR_NTP_BACKGROUND);
 
   // Generate the replacements.
-  std::vector<std::string> subst;
+  std::map<std::string, std::string> substitutions;
 
   // Cache-buster for background.
-  subst.push_back(
-      profile_->GetPrefs()->GetString(prefs::kCurrentThemeID));  // $1
+  substitutions["themeId"] =
+      profile_->GetPrefs()->GetString(prefs::kCurrentThemeID);
 
   // Colors.
-  subst.push_back(SkColorToRGBAString(color_background));  // $2
-  subst.push_back(GetNewTabBackgroundCSS(tp, false));  // $3
-  subst.push_back(GetNewTabBackgroundCSS(tp, true));  // $4
-  subst.push_back(GetNewTabBackgroundTilingCSS(tp));  // $5
+  substitutions["colorBackground"] = SkColorToRGBAString(color_background);
+  substitutions["backgroundBarDetached"] = GetNewTabBackgroundCSS(tp, false);
+  substitutions["backgroundBarAttached"] = GetNewTabBackgroundCSS(tp, true);
+  substitutions["backgroundTiling"] = GetNewTabBackgroundTilingCSS(tp);
 
   // Get our template.
   static const base::StringPiece new_tab_theme_css(
       ResourceBundle::GetSharedInstance().GetRawDataResource(
           IDR_NEW_INCOGNITO_TAB_THEME_CSS));
 
+  std::string source_string(new_tab_theme_css.data(),
+                            new_tab_theme_css.length());
+
   // Create the string from our template and the replacements.
-  std::string full_css = ReplaceStringPlaceholders(
-      new_tab_theme_css, subst, NULL);
+  std::string full_css =
+      ui::ReplaceTemplateExpressions(source_string, substitutions);
 
   new_tab_incognito_css_ = base::RefCountedString::TakeString(&full_css);
 }
 
 void NTPResourceCache::CreateNewTabGuestCSS() {
   ui::ThemeProvider* tp = ThemeServiceFactory::GetForProfile(profile_);
   DCHECK(tp);
 
   // Get our theme colors
   SkColor color_background =
       GetThemeColor(tp, ThemeProperties::COLOR_NTP_BACKGROUND);
 
   // Generate the replacements.
-  std::vector<std::string> subst;
+  std::map<std::string, std::string> substitutions;
 
   // Cache-buster for background.
-  subst.push_back(
-      profile_->GetPrefs()->GetString(prefs::kCurrentThemeID));  // $1
+  substitutions["themeId"] =
+      profile_->GetPrefs()->GetString(prefs::kCurrentThemeID);
 
   // Colors.
-  subst.push_back(SkColorToRGBAString(color_background));  // $2
-  subst.push_back(GetNewTabBackgroundCSS(tp, false));  // $3
-  subst.push_back(GetNewTabBackgroundCSS(tp, true));  // $4
-  subst.push_back(GetNewTabBackgroundTilingCSS(tp));  // $5
+  substitutions["colorBackground"] = SkColorToRGBAString(color_background);
+  substitutions["backgroundBarDetached"] = GetNewTabBackgroundCSS(tp, false);
+  substitutions["backgroundBarAttached"] = GetNewTabBackgroundCSS(tp, true);
+  substitutions["backgroundTiling"] = GetNewTabBackgroundTilingCSS(tp);
 
   // Get our template.
   static const base::StringPiece new_tab_theme_css(
       ResourceBundle::GetSharedInstance().GetRawDataResource(
           IDR_NEW_INCOGNITO_TAB_THEME_CSS));
 
+  std::string source_string(new_tab_theme_css.data(),
+                            new_tab_theme_css.length());

[Dan Beam, 2015/07/09 19:26:01]

if we could do less *potential* copies, that'd be better

+
   // Create the string from our template and the replacements.
-  std::string full_css = ReplaceStringPlaceholders(
-      new_tab_theme_css, subst, NULL);
+  std::string full_css =
+      ui::ReplaceTemplateExpressions(source_string, substitutions);
 
   new_tab_guest_css_ = base::RefCountedString::TakeString(&full_css);
 }
 
 void NTPResourceCache::CreateNewTabCSS() {
   ui::ThemeProvider* tp = ThemeServiceFactory::GetForProfile(profile_);
   DCHECK(tp);
 
   // Get our theme colors
   SkColor color_background =
       GetThemeColor(tp, ThemeProperties::COLOR_NTP_BACKGROUND);
   SkColor color_text = GetThemeColor(tp, ThemeProperties::COLOR_NTP_TEXT);
-  SkColor color_link = GetThemeColor(tp, ThemeProperties::COLOR_NTP_LINK);
-  SkColor color_link_underline =
-      GetThemeColor(tp, ThemeProperties::COLOR_NTP_LINK_UNDERLINE);
-
-  SkColor color_section =
-      GetThemeColor(tp, ThemeProperties::COLOR_NTP_SECTION);
-  SkColor color_section_text =
-      GetThemeColor(tp, ThemeProperties::COLOR_NTP_SECTION_TEXT);
-  SkColor color_section_link =
-      GetThemeColor(tp, ThemeProperties::COLOR_NTP_SECTION_LINK);
-  SkColor color_section_link_underline =
-      GetThemeColor(tp, ThemeProperties::COLOR_NTP_SECTION_LINK_UNDERLINE);
-  SkColor color_section_header_text =
-      GetThemeColor(tp, ThemeProperties::COLOR_NTP_SECTION_HEADER_TEXT);
-  SkColor color_section_header_text_hover =
-      GetThemeColor(tp, ThemeProperties::COLOR_NTP_SECTION_HEADER_TEXT_HOVER);
-  SkColor color_section_header_rule =
-      GetThemeColor(tp, ThemeProperties::COLOR_NTP_SECTION_HEADER_RULE);
-  SkColor color_section_header_rule_light =
-      GetThemeColor(tp, ThemeProperties::COLOR_NTP_SECTION_HEADER_RULE_LIGHT);
   SkColor color_text_light =
       GetThemeColor(tp, ThemeProperties::COLOR_NTP_TEXT_LIGHT);
 
   SkColor color_header =
       GetThemeColor(tp, ThemeProperties::COLOR_NTP_HEADER);
   // Generate a lighter color for the header gradients.
   color_utils::HSL header_lighter;
   color_utils::SkColorToHSL(color_header, &header_lighter);
   header_lighter.l += (1 - header_lighter.l) * 0.33;
-  SkColor color_header_gradient_light =
-      color_utils::HSLToSkColor(header_lighter, SkColorGetA(color_header));
 
   // Generate section border color from the header color. See
   // BookmarkBarView::Paint for how we do this for the bookmark bar
   // borders.
   SkColor color_section_border =
       SkColorSetARGB(80,
                      SkColorGetR(color_header),
                      SkColorGetG(color_header),
                      SkColorGetB(color_header));
 
   // Generate the replacements.
-  std::vector<std::string> subst;
+  std::map<std::string, std::string> substitutions;
 
   // Cache-buster for background.
-  subst.push_back(
-      profile_->GetPrefs()->GetString(prefs::kCurrentThemeID));  // $1
+  substitutions["themeId"] =
+      profile_->GetPrefs()->GetString(prefs::kCurrentThemeID);
 
   // Colors.
-  subst.push_back(SkColorToRGBAString(color_background));  // $2
-  subst.push_back(GetNewTabBackgroundCSS(tp, false));  // $3
-  subst.push_back(GetNewTabBackgroundCSS(tp, true));  // $4
-  subst.push_back(GetNewTabBackgroundTilingCSS(tp));  // $5
-  subst.push_back(SkColorToRGBAString(color_header));  // $6
-  subst.push_back(SkColorToRGBAString(color_header_gradient_light));  // $7
-  subst.push_back(SkColorToRGBAString(color_text));  // $8
-  subst.push_back(SkColorToRGBAString(color_link));  // $9
-  subst.push_back(SkColorToRGBAString(color_section));  // $10
-  subst.push_back(SkColorToRGBAString(color_section_border));  // $11
-  subst.push_back(SkColorToRGBAString(color_section_text));  // $12
-  subst.push_back(SkColorToRGBAString(color_section_link));  // $13
-  subst.push_back(SkColorToRGBAString(color_link_underline));  // $14
-  subst.push_back(SkColorToRGBAString(color_section_link_underline));  // $15
-  subst.push_back(SkColorToRGBAString(color_section_header_text));  // $16
-  subst.push_back(SkColorToRGBAString(
-      color_section_header_text_hover));  // $17
-  subst.push_back(SkColorToRGBAString(color_section_header_rule));  // $18
-  subst.push_back(SkColorToRGBAString(
-      color_section_header_rule_light));  // $19
-  subst.push_back(SkColorToRGBAString(
-      SkColorSetA(color_section_header_rule, 0)));  // $20
-  subst.push_back(SkColorToRGBAString(color_text_light));  // $21
-  subst.push_back(SkColorToRGBComponents(color_section_border));  // $22
-  subst.push_back(SkColorToRGBComponents(color_text));  // $23
+  substitutions["colorBackground"] = SkColorToRGBAString(color_background);
+  substitutions["backgroundBarDetached"] = GetNewTabBackgroundCSS(tp, false);
+  substitutions["backgroundBarAttached"] = GetNewTabBackgroundCSS(tp, true);
+  substitutions["backgroundTiling"] = GetNewTabBackgroundTilingCSS(tp);
+  substitutions["colorTextCall"] = SkColorToRGBAString(color_text);
+  substitutions["colorSectionBorder"] =
+      SkColorToRGBAString(color_section_border);
+  substitutions["colorTextLight"] = SkColorToRGBAString(color_text_light);
+  substitutions["colorSectionBorder"] =
+      SkColorToRGBComponents(color_section_border);
+  substitutions["colorText"] = SkColorToRGBComponents(color_text);
 
   // Get our template.
   static const base::StringPiece new_tab_theme_css(
       ResourceBundle::GetSharedInstance().GetRawDataResource(
           IDR_NEW_TAB_4_THEME_CSS));
 
+  std::string source_string(new_tab_theme_css.data(),
+                            new_tab_theme_css.length());
+
   // Create the string from our template and the replacements.
   std::string css_string;
-  css_string = ReplaceStringPlaceholders(new_tab_theme_css, subst, NULL);
+  css_string = ui::ReplaceTemplateExpressions(source_string, substitutions);
   new_tab_css_ = base::RefCountedString::TakeString(&css_string);
 }