Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1220793002: Make webexposed/global-interface-listing tests skip JS builtins (Closed)

Created:
5 years, 5 months ago by adamk
Modified:
5 years, 5 months ago
CC:
blink-reviews, v8-dev
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Make webexposed/global-interface-listing tests skip JS builtins JS builtins, and their properties, are handled by V8, not Blink. Having this test enumerate over these builtin objects does nothing but add busywork for V8 developers. This patch addresses the problem by adding a blacklist of builtin JS constructors, and not outputting anything for such builtins. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198071

Patch Set 1 #

Messages

Total messages: 13 (5 generated)
adamk
5 years, 5 months ago (2015-06-29 22:25:47 UTC) #2
adamk
5 years, 5 months ago (2015-06-29 22:26:16 UTC) #4
arv (Not doing code reviews)
Nice! LGTM
5 years, 5 months ago (2015-06-29 22:37:24 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220793002/1
5 years, 5 months ago (2015-06-29 23:18:19 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-30 01:24:05 UTC) #9
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-06-30 08:00:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220793002/1
5 years, 5 months ago (2015-06-30 16:18:35 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 16:21:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198071

Powered by Google App Engine
This is Rietveld 408576698