Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: test/mjsunit/compiler/stubs/floor-stub.js

Issue 1220783006: Revert of Add unoptimized/optimized variants of MathFloor TF code stub (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/compiler/test-run-stubs.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --allow-natives-syntax --expose-natives-as=builtins --noalways-opt --t urbo-filter=* 28 // Flags: --allow-natives-syntax --expose-natives-as=builtins --noalways-opt
29 29
30 const kExtraTypeFeedbackMinusZeroSentinel = 1; 30 const kExtraTypeFeedbackMinusZeroSentinel = 1;
31 const kFirstJSFunctionTypeFeedbackIndex = 5;
32 const kFirstSlotExtraTypeFeedbackIndex = 5; 31 const kFirstSlotExtraTypeFeedbackIndex = 5;
33 32
34 (function() { 33 (function(){
35 var stub1 = builtins.MathFloorStub("MathFloorStub", 1); 34 var floorFunc = function() {
36 var tempForTypeVector = function(d) { 35 Math.floor(NaN);
37 return Math.round(d);
38 } 36 }
39 tempForTypeVector(5); 37 // Execute the function once to make sure it has a type feedback vector.
40 var tv = %GetTypeFeedbackVector(tempForTypeVector); 38 floorFunc(5);
41 var floorFunc1 = function(v, first) { 39 var stub = builtins.MathFloorStub("MathFloorStub", 0);
42 if (first) return;
43 return stub1(stub1, kFirstSlotExtraTypeFeedbackIndex - 1, tv, undefined, v);
44 };
45 %OptimizeFunctionOnNextCall(stub1);
46 floorFunc1(5, true);
47 %FixedArraySet(tv, kFirstSlotExtraTypeFeedbackIndex - 1, stub1);
48 assertTrue(kExtraTypeFeedbackMinusZeroSentinel !== 40 assertTrue(kExtraTypeFeedbackMinusZeroSentinel !==
49 %FixedArrayGet(tv, kFirstSlotExtraTypeFeedbackIndex)); 41 %FixedArrayGet(%GetTypeFeedbackVector(floorFunc),
50 assertEquals(5.0, floorFunc1(5.5)); 42 kFirstSlotExtraTypeFeedbackIndex));
43 assertEquals(5.0, stub(floorFunc, 4, 5.5));
51 assertTrue(kExtraTypeFeedbackMinusZeroSentinel !== 44 assertTrue(kExtraTypeFeedbackMinusZeroSentinel !==
52 %FixedArrayGet(tv, kFirstSlotExtraTypeFeedbackIndex)); 45 %FixedArrayGet(%GetTypeFeedbackVector(floorFunc),
46 kFirstSlotExtraTypeFeedbackIndex));
53 // Executing floor such that it returns -0 should set the proper sentinel in 47 // Executing floor such that it returns -0 should set the proper sentinel in
54 // the feedback vector. 48 // the feedback vector.
55 assertEquals(-Infinity, 1/floorFunc1(-0)); 49 assertEquals(-Infinity, 1/stub(floorFunc, 4, -0));
56 assertEquals(kExtraTypeFeedbackMinusZeroSentinel, 50 assertEquals(kExtraTypeFeedbackMinusZeroSentinel,
57 %FixedArrayGet(tv, kFirstSlotExtraTypeFeedbackIndex)); 51 %FixedArrayGet(%GetTypeFeedbackVector(floorFunc),
58 %ClearFunctionTypeFeedback(floorFunc1); 52 kFirstSlotExtraTypeFeedbackIndex));
53 %ClearFunctionTypeFeedback(floorFunc);
59 })(); 54 })();
OLDNEW
« no previous file with comments | « test/cctest/compiler/test-run-stubs.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698