Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1220783006: Revert of Add unoptimized/optimized variants of MathFloor TF code stub (Closed)

Created:
5 years, 5 months ago by danno
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add unoptimized/optimized variants of MathFloor TF code stub (patchset #4 id:60001 of https://codereview.chromium.org/1225943002/) Reason for revert: Failure on compiling runtime.js on windows Original issue's description: > Add unoptimized/optimized variants of MathFloor TF code stub > > - Add a TurboFanIC class, derived from TurboFanCodeStub, that > automatically distinguishes between versions of the IC called from > optimized and unoptimized code. > - Add appropriate InterfaceDescriptors for both the versions of the > stub called from unoptimized and optimized code > - Change the MathFloor TF stub generator to output either the > for-optimized or for-unoptimized version based on the minor_key > parameter. > > Committed: https://crrev.com/8f13b655b8a10dae2116dd18b32f09337bb2d410 > Cr-Commit-Position: refs/heads/master@{#29534} TBR=mvstanton@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7fc183af06d48fb1e034e296e5006b1f02bb81a3 Cr-Commit-Position: refs/heads/master@{#29535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -230 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M src/code-stubs.h View 5 chunks +8 lines, -57 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +5 lines, -16 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +11 lines, -25 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M src/runtime.js View 2 chunks +4 lines, -24 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M test/cctest/compiler/test-run-stubs.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M test/mjsunit/compiler/stubs/floor-stub.js View 1 chunk +16 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danno
Created Revert of Add unoptimized/optimized variants of MathFloor TF code stub
5 years, 5 months ago (2015-07-08 15:00:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220783006/1
5 years, 5 months ago (2015-07-08 15:00:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 15:00:35 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 15:00:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fc183af06d48fb1e034e296e5006b1f02bb81a3
Cr-Commit-Position: refs/heads/master@{#29535}

Powered by Google App Engine
This is Rietveld 408576698