Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1220783002: Fix flaky test ensuring scrolling triggers layout. (Closed)

Created:
5 years, 5 months ago by tdresser
Modified:
5 years, 5 months ago
Reviewers:
Rick Byers
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix flaky test ensuring scrolling triggers layout. In cases where smooth scrolling is enabled, this test was previously flaky. Disabling smooth scrolling should fix the issue. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M LayoutTests/fast/scroll-behavior/overflow-scroll-triggers-layout.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tdresser
PTAL
5 years, 5 months ago (2015-06-29 19:40:28 UTC) #2
Rick Byers
LGTM
5 years, 5 months ago (2015-06-29 20:13:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220783002/1
5 years, 5 months ago (2015-06-29 20:14:56 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 21:17:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198021

Powered by Google App Engine
This is Rietveld 408576698