Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1220743002: [android] Remove legacy architecture configs from perf runner. (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
Reviewers:
ulan, tandrii(chromium)
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[android] Remove legacy architecture configs from perf runner. The android_* configs were never real v8 target architectures, only make targets. This doesn't make sense with ninja anymore. BUG=chromium:502176 LOG=n NOTRY=true Committed: https://crrev.com/b2348f42c010f727164e45b3044cc2555841afdd Cr-Commit-Position: refs/heads/master@{#29349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M tools/run_perf.py View 4 chunks +6 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
PTAL
5 years, 5 months ago (2015-06-29 14:23:50 UTC) #2
tandrii(chromium)
lgtm
5 years, 5 months ago (2015-06-29 15:02:11 UTC) #3
ulan
lgtm
5 years, 5 months ago (2015-06-29 15:02:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220743002/1
5 years, 5 months ago (2015-06-29 15:05:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-29 15:07:19 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 15:07:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2348f42c010f727164e45b3044cc2555841afdd
Cr-Commit-Position: refs/heads/master@{#29349}

Powered by Google App Engine
This is Rietveld 408576698