Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: Source/core/paint/InlineTextBoxPainter.cpp

Issue 1220733012: Display transparent text when it's being searched and selected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Incorporated comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/paint/InlineTextBoxPainter.cpp
diff --git a/Source/core/paint/InlineTextBoxPainter.cpp b/Source/core/paint/InlineTextBoxPainter.cpp
index a7503c4527704aaa22ce931760ab6fc094b4e0ec..82fd02359b0e9f5cb3f3e407c96fa166fb0e58a0 100644
--- a/Source/core/paint/InlineTextBoxPainter.cpp
+++ b/Source/core/paint/InlineTextBoxPainter.cpp
@@ -813,6 +813,19 @@ void InlineTextBoxPainter::paintTextMatchMarker(GraphicsContext* pt, const Layou
GraphicsContextStateSaver stateSaver(*pt);
pt->clip(FloatRect(boxOrigin.x().toFloat(), (boxOrigin.y() - deltaY).toFloat(), m_inlineTextBox.logicalWidth().toFloat(), selHeight));
pt->drawHighlightForText(font, run, FloatPoint(boxOrigin.x().toFloat(), (boxOrigin.y() - deltaY).toFloat()), selHeight, color, sPos, ePos);
+
+ // Also Highlight the text with color:transparent
+ if (style.visitedDependentColor(CSSPropertyColor) == Color::transparent) {
+ int length = m_inlineTextBox.len();
+ StringView string = m_inlineTextBox.layoutObject().text().createView();
+ TextRun textRun = m_inlineTextBox.constructTextRun(style, font, string, length, 0);
pdr. 2015/07/21 22:03:57 You're constructing a new textrun here. Why doesn'
+ TextPainter::Style textStyle = TextPainter::textPaintingStyle(m_inlineTextBox.layoutObject(), style, true, false);
+ LayoutRect boxRect(boxOrigin, LayoutSize(m_inlineTextBox.logicalWidth(), m_inlineTextBox.logicalHeight()));
+ LayoutPoint textOrigin(boxOrigin.x(), boxOrigin.y() + font.fontMetrics().ascent());
+ TextPainter textPainter(pt, font, textRun, textOrigin, boxRect, m_inlineTextBox.isHorizontal());
+
+ textPainter.paint(sPos, ePos, length, textStyle, 0);
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698