Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1220733009: gn_migration.gypi: Do not pull aura_unittests_run unless use_aura==1. (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke, sky
CC:
chromium-reviews, sky
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn_migration.gypi: Do not pull aura_unittests_run unless use_aura==1. This was a regression in 49f497d7d9c9c6c665abec0ddfbc0df07c3cd6c9 which caused compilation failure when building everything on OSX. TBR=dpranke@chromium.org BUG=98637 NOTRY=true Committed: https://crrev.com/e0f3d6391782f114ddd35babfff4b5f1fd9b61d6 Cr-Commit-Position: refs/heads/master@{#336802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M build/gn_migration.gypi View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
M-A Ruel
5 years, 5 months ago (2015-06-30 17:06:28 UTC) #1
sky
LGTM
5 years, 5 months ago (2015-06-30 17:07:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220733009/1
5 years, 5 months ago (2015-06-30 17:09:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 17:15:45 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 17:16:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0f3d6391782f114ddd35babfff4b5f1fd9b61d6
Cr-Commit-Position: refs/heads/master@{#336802}

Powered by Google App Engine
This is Rietveld 408576698