Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 1220733006: Add support for drawBitmapRect() to SkMiniRecorder. (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add support for drawBitmapRect() to SkMiniRecorder. BUG=chromium:503705 Committed: https://skia.googlesource.com/skia/+/64b4c789fd1721d6804ccb5a9ceae39df03a5711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -7 lines) Patch
M src/core/SkMiniRecorder.h View 2 chunks +14 lines, -4 lines 0 comments Download
M src/core/SkMiniRecorder.cpp View 3 chunks +16 lines, -0 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 4 chunks +7 lines, -2 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkRecords.h View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein_C
5 years, 5 months ago (2015-06-30 15:18:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220733006/1
5 years, 5 months ago (2015-06-30 15:19:17 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-30 15:26:15 UTC) #6
mtklein_C
Take a look? Looks like this makes playing back a singleton drawBitmapRect() picture about 40% ...
5 years, 5 months ago (2015-07-01 16:09:40 UTC) #7
reed1
lgtm
5 years, 5 months ago (2015-07-01 20:38:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220733006/1
5 years, 5 months ago (2015-07-01 20:39:39 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 20:56:58 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/64b4c789fd1721d6804ccb5a9ceae39df03a5711

Powered by Google App Engine
This is Rietveld 408576698