Issue 12207207: Added system thread manager class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12207207: Added system thread manager class. (Closed)

Created:
7 years, 10 months ago by Hannes Payer (out of office)

Modified:
7 years, 9 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Added system thread manager class. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13757

Patch Set 4 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -11 lines)			Patch
M	src/flag-definitions.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/isolate.h	View	1 2 3	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/isolate.cc	View	1 2 3	5 chunks	+37 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM, with one comment. https://codereview.chromium.org/12207207/diff/3001/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/12207207/diff/3001/src/isolate.cc#newcode142 src/isolate.cc:142: return number_of_cores; Let's cap the ...

7 years, 9 months ago (2013-02-27 12:13:08 UTC) #2

Hannes Payer (out of office)

https://codereview.chromium.org/12207207/diff/3001/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/12207207/diff/3001/src/isolate.cc#newcode142 src/isolate.cc:142: return number_of_cores; On 2013/02/27 12:13:09, Michael Starzinger wrote: > ...

7 years, 9 months ago (2013-02-27 12:43:29 UTC) #3

Hannes Payer (out of office)

7 years, 9 months ago (2013-02-27 12:56:00 UTC) #4

Message was sent while issue was closed.

Committed manually as r13757 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12207207: Added system thread manager class. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages