Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 12207186: split test_registrar target into a new win8_tests.gyp. (Closed)

Created:
7 years, 10 months ago by Dirk Pranke
Modified:
7 years, 10 months ago
Reviewers:
ananta, sky, robert
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

split test_registrar target into a new win8_tests.gyp. r171366 introduced a new 'test_registrar' binary that depends on chrome into the win8.gyp file; unfortunately, the win8.gyp file is needed by printing.gyp, which is needed by webkit_support, making the webkit files now have a circular dependency on chrome, and breaking the webkit.org win builds, which don't check out chrome/ at all. This change fixes this temporarily (?) by moving the test binary into a separate gyp file, but we probably need to do something else to avoid making ash and win8 depend on chrome. R=ananta@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182605

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -24 lines) Patch
M ash/ash.gyp View 1 chunk +1 line, -1 line 0 comments Download
M win8/win8.gyp View 1 chunk +0 lines, -23 lines 0 comments Download
A win8/win8_tests.gyp View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dirk Pranke
7 years, 10 months ago (2013-02-14 22:23:19 UTC) #1
ananta
lgtm
7 years, 10 months ago (2013-02-14 22:27:18 UTC) #2
sky
7 years, 10 months ago (2013-02-14 22:28:47 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698