Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2609)

Unified Diff: buildbot/buildbot_standard.py

Issue 12207165: Mac x86_64: Mach exception support (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: buildbot/buildbot_standard.py
===================================================================
--- buildbot/buildbot_standard.py (revision 10826)
+++ buildbot/buildbot_standard.py (working copy)
@@ -336,15 +336,16 @@
# http://code.google.com/p/nativeclient/issues/detail?id=2473
bug2473 = (context['clang'] or context['asan']) and context['mode'] == 'opt'
if context.Mac() and context['arch'] != 'arm' and not bug2473:
- # We don't run all tests on x86-64 Mac yet, because not all pass
- # yet, and because it would slow down the bots too much. We just
- # run a small set of tests that have previously been fixed to
- # pass, in order to prevent regressions.
+ # We don't run all tests on x86-64 Mac yet because it would slow
+ # down the bots too much. We just run a small set of tests that
+ # have previously been fixed to pass, in order to prevent
+ # regressions.
# TODO(mseaborn): Remove this when we have bots dedicated to
# testing x86-64 Mac.
with Step('minimal x86-64 test', status, halt_on_fail=False):
SCons(context, parallel=True, platform='x86-64',
- args=['run_hello_world_test',
+ args=['exception_tests',
Mark Mentovai 2013/02/15 22:30:30 I could add more tests here since they do all pass
+ 'run_hello_world_test',
'run_execute_data_test',
'run_nacl_signal_test',
'run_signal_frame_test',
« no previous file with comments | « no previous file | src/trusted/service_runtime/build.scons » ('j') | src/trusted/service_runtime/nacl_app_thread.c » ('J')

Powered by Google App Engine
This is Rietveld 408576698