Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 12207155: Revert 182194 (Closed)

Created:
7 years, 10 months ago by Randy Smith (Not in Mondays)
Modified:
7 years, 10 months ago
Reviewers:
jeremya
CC:
chromium-reviews, Aaron Boodman, jeremya+watch_chromium.org, sail+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert 182194 > Fix issue 174250, crash when reloading packaged app. > > When a shell window was closed, it wasn't removed from the registry immediately > (it was removed in a callback from OnNativeClose, which happens a bit later.) > This meant that when the app was loaded again, the window was still in the > registry with a stale pointer to the old extension. ExtensionSettingsHandler > was tickling this by iterating shell windows on extension load. > > BUG=174250 > > > Review URL: https://chromiumcodereview.appspot.com/12210107 TBR=jeremya@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -68 lines) Patch
M chrome/browser/extensions/platform_app_browsertest.cc View 3 chunks +1 line, -20 lines 0 comments Download
M chrome/browser/extensions/shell_window_registry.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 4 chunks +6 lines, -22 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/native_app_window_gtk.cc View 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Randy Smith (Not in Mondays)
7 years, 10 months ago (2013-02-13 15:52:01 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698