Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 12207153: Drop latin-1 check from BasicJsonStringifier::DoNotEscape (Closed)

Created:
7 years, 10 months ago by dcarney
Modified:
7 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Drop latin-1 check from BasicJsonStringifier::DoNotEscape R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13660

Patch Set 1 #

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -5 lines) Patch
M src/json-stringifier.h View 1 2 chunks +42 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
Like discussed offline, for the one-byte case return c >= '#' && c <= '~' ...
7 years, 10 months ago (2013-02-13 14:44:51 UTC) #1
Yang
7 years, 10 months ago (2013-02-13 14:54:18 UTC) #2
On 2013/02/13 14:44:51, Yang wrote:
> Like discussed offline, for the one-byte case
> 
>   return c >= '#' && c <= '~' && c != '\\';
> 
> and for the two-byte case
> 
>   return c >= '#' && c != '\\' && c != 0x7f;

LGTM.

Powered by Google App Engine
This is Rietveld 408576698