Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 12207150: [Cleanup] Files.app: Fix wrong style in JavaScript Code. (Closed)

Created:
7 years, 10 months ago by yoshiki
Modified:
7 years, 10 months ago
Reviewers:
mtomasz, Haruki Sato
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

[Cleanup] Files.app: Fix wrong style in JavaScript Code. BUG=175657 TBR=mtomasz@chromium.org, haruki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182232

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -29 lines) Patch
M chrome/browser/resources/file_manager/js/image_editor/image_editor.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/metadata/function_parallel.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/file_manager/js/metadata/function_sequence.js View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/resources/file_manager/js/metadata/id3_parser.js View 11 chunks +14 lines, -15 lines 0 comments Download
M chrome/browser/resources/file_manager/js/metadata/image_parsers.js View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/12207150/2001
7 years, 10 months ago (2013-02-13 12:45:00 UTC) #1
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 12:45:04 UTC) #2
Presubmit check for 12207150-2001 failed and returned exit status 1.

INFO:root:Found 5 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/resources/PRESUBMIT.py

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

See the JavaScript style guide at
http://www.chromium.org/developers/web-development-style-guide#TOC-JavaScript
and if you have any feedback about the JavaScript PRESUBMIT check, contact
tbreisacher@chromium.org or dbeam@chromium.org

** Presubmit Warnings **
Found JavaScript style violations in
chrome/browser/resources/file_manager/js/metadata/function_parallel.js:
  line 9: E0213: Missing type in @param tag
 * @param steps             array of functions to invoke in parallel
   ^^^^^^
  line 10: E0213: Missing type in @param tag
 * @param callback          callback to invoke on success
   ^^^^^^
  line 11: E0213: Missing type in @param tag
 * @param failureCallback   callback to invoke on failure
   ^^^^^^
  line 13: E0210: Missing docs for parameter: "name"
function FunctionParallel(name, steps, logger, callback, failureCallback) {
                                                                        ^^
  line 13: E0210: Missing docs for parameter: "logger"
function FunctionParallel(name, steps, logger, callback, failureCallback) {
                                                                        ^^
  line 34: E0213: Missing type in @param tag
 * @param err error message
   ^^^^^^
  line 36: E0221: Member "FunctionParallel.prototype.onError_" must have
@private JsDoc.
FunctionParallel.prototype.onError_ = function(err) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 48: E0221: Member "FunctionParallel.prototype.nextStep_" must have
@private JsDoc.
FunctionParallel.prototype.nextStep_ = function() {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 58: E0210: Missing docs for parameter: "var_args"
FunctionParallel.prototype.start = function(var_args) {
                                                    ^^
  line 60: E0120: Binary operator should go on previous line "+"
                    + arguments.length + ' argument(s)');
                    ^

Found JavaScript style violations in
chrome/browser/resources/file_manager/js/metadata/function_sequence.js:
  line 14: E0210: Missing docs for parameter: "name"
function FunctionSequence(name, steps, logger, callback, failureCallback) {
                                                                        ^^
  line 14: E0212: Parameter mismatch: got "failureCallback", expected "callback"
function FunctionSequence(name, steps, logger, callback, failureCallback) {
                                                                        ^^
  line 53: E0213: Missing type in @param tag
 * @param err error message
   ^^^^^^
  line 55: E0221: Member "FunctionSequence.prototype.onError_" must have
@private JsDoc.
FunctionSequence.prototype.onError_ = function(err) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 70: E0221: Member "FunctionSequence.prototype.finish_" must have @private
JsDoc.
FunctionSequence.prototype.finish_ = function() {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 83: E0221: Member "FunctionSequence.prototype.nextStep_" must have
@private JsDoc.
FunctionSequence.prototype.nextStep_ = function(var_args) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 83: E0210: Missing docs for parameter: "var_args"
FunctionSequence.prototype.nextStep_ = function(var_args) {
                                                        ^^
  line 106: E0210: Missing docs for parameter: "var_args"
FunctionSequence.prototype.start = function(var_args) {
                                                    ^^
  line 120: E0221: Member "FunctionSequence.prototype.apply_" must have @private
JsDoc.
FunctionSequence.prototype.apply_ = function(obj, args) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 120: E0210: Missing docs for parameter: "obj"
FunctionSequence.prototype.apply_ = function(obj, args) {
                                                      ^^
  line 120: E0210: Missing docs for parameter: "args"
FunctionSequence.prototype.apply_ = function(obj, args) {
                                                      ^^

Found JavaScript style violations in
chrome/browser/resources/file_manager/js/metadata/id3_parser.js:
  line 20: E0214: Missing description in @return tag
 * @return {int}
   ^^^^^^^
  line 22: E0221: Member "Id3Parser.readSynchSafe_" must have @private JsDoc.
Id3Parser.readSynchSafe_ = function(reader, length) {
^^^^^^^^^^^^^^^^^^^^^^^^
  line 43: E0214: Missing description in @return tag
 * @return {int}
   ^^^^^^^
  line 45: E0221: Member "Id3Parser.readUInt24_" must have @private JsDoc.
Id3Parser.readUInt24_ = function(reader) {
^^^^^^^^^^^^^^^^^^^^^
  line 57: E0221: Member "Id3Parser.prototype.readString_" must have @private
JsDoc.
Id3Parser.prototype.readString_ = function(reader, encoding, size) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 56: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 88: E0221: Member "Id3Parser.prototype.readTextFrame_" must have @private
JsDoc.
Id3Parser.prototype.readTextFrame_ = function(reader,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 104: E0221: Member "Id3Parser.prototype.readUserDefinedTextFrame_" must
have @private JsDoc.
Id3Parser.prototype.readUserDefinedTextFrame_ = function(reader,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 121: E0220: No docs found for member 'Id3Parser.prototype.readPIC_'
Id3Parser.prototype.readPIC_ = function(reader, majorVersion, frame, end) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 137: E0220: No docs found for member 'Id3Parser.prototype.readAPIC_'
Id3Parser.prototype.readAPIC_ = function(reader, majorVersion, frame, end) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 160: E0221: Member "Id3Parser.prototype.readFrame_" must have @private
JsDoc.
Id3Parser.prototype.readFrame_ = function(reader, majorVersion) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 160: E0210: Missing docs for parameter: "majorVersion"
Id3Parser.prototype.readFrame_ = function(reader, majorVersion) {
                                                              ^^
  line 219: E0220: No docs found for member 'Id3Parser.prototype.parse'
Id3Parser.prototype.parse = function(file, metadata, callback, onError) {
^^^^^^^^^^^^^^^^^^^^^^^^^
  line 231: E0213: Missing type in @param tag
         * @param file - file which bytes to read.
           ^^^^^^
  line 240: E0213: Missing type in @param tag
         * @param file file which tags are being extracted.
           ^^^^^^
  line 285: E0213: Missing type in @param tag
         * @param file to check and continue reading if ID3 metadata found
           ^^^^^^
  line 306: E0213: Missing type in @param tag
         * @param file being parsed.
           ^^^^^^

Found JavaScript style violations in
chrome/browser/resources/file_manager/js/metadata/image_parsers.js:
  line 14: E0220: No docs found for member 'SimpleImageParser.prototype.parse'
SimpleImageParser.prototype.parse = function(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 36: E0220: No docs found for member 'PngParser.prototype.parseHeader'
PngParser.prototype.parseHeader = function(metadata, br) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 61: E0220: No docs found for member 'BmpParser.prototype.parseHeader'
BmpParser.prototype.parseHeader = function(metadata, br) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 82: E0220: No docs found for member 'GifParser.prototype.parseHeader'
GifParser.prototype.parseHeader = function(metadata, br) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Presubmit checks took 1.5s to calculate.

Powered by Google App Engine
This is Rietveld 408576698