Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 12207148: Getting rid of SpdyFramer::GetControlFrameStreamId(), which cleans up the code and also makes it ea… (Closed)

Created:
7 years, 10 months ago by akalin
Modified:
7 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Getting rid of SpdyFramer::GetControlFrameStreamId(), which cleans up the code and also makes it easier to move forward with SPDY 4 work. This lands server change 42008414. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -75 lines) Patch
net/spdy/spdy_framer.h View 2 chunks +2 lines, -8 lines 0 comments Download
net/spdy/spdy_framer.cc View 6 chunks +20 lines, -56 lines 0 comments Download
net/spdy/spdy_framer_test.cc View 7 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
akalin
+rch for review
7 years, 10 months ago (2013-02-13 06:52:10 UTC) #1
Ryan Hamilton
lgtm
7 years, 10 months ago (2013-02-13 16:27:00 UTC) #2
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 19:52:00 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698