Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 12207146: changing std::vector to std::set for all_tiles_ (Closed)

Created:
7 years, 10 months ago by whunt
Modified:
7 years, 10 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

changing std::vector to std::set for all_tiles_ This improves the performance of removing a tile from the list to O(log(n)) from O(n). The O(n) removal time was showing up as lag spikes in a trace. BUG=175939 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182297

Patch Set 1 #

Patch Set 2 : making iterator const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M cc/tile_manager.h View 2 chunks +3 lines, -1 line 0 comments Download
M cc/tile_manager.cc View 1 4 chunks +13 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
whunt
7 years, 10 months ago (2013-02-13 05:26:23 UTC) #1
whunt
7 years, 10 months ago (2013-02-13 05:26:49 UTC) #2
ccameron
lgtm
7 years, 10 months ago (2013-02-13 05:28:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/whunt@chromium.org/12207146/1
7 years, 10 months ago (2013-02-13 05:29:29 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-13 05:51:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/whunt@chromium.org/12207146/7004
7 years, 10 months ago (2013-02-13 06:14:43 UTC) #6
nduca
seriously lgtm
7 years, 10 months ago (2013-02-13 06:38:16 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) aura_unittests, browser_tests, content_browsertests, ppapi_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=83862
7 years, 10 months ago (2013-02-13 06:39:46 UTC) #8
jamesr
Super cool! But how does this make the operations O(1)? I thought std::set<> could only ...
7 years, 10 months ago (2013-02-13 06:43:29 UTC) #9
whunt
On 2013/02/13 06:43:29, jamesr wrote: > Super cool! But how does this make the operations ...
7 years, 10 months ago (2013-02-13 20:06:18 UTC) #10
nduca
7 years, 10 months ago (2013-02-13 20:33:46 UTC) #11
Message was sent while issue was closed.
Committed manually as r182297.

Powered by Google App Engine
This is Rietveld 408576698