Revert 182037

Revert 182037
> Create unit-test for exiting context menus via mouse button
> 
> Added a unit-test to BookmarkBarViewTest. It opens a context menu. The menu
> is dismissed by clicking the mouse outside of it. The underlying view gets
> the mouse event after the context menu has exited.
> 
> See also: https://chromiumcodereview.appspot.com/11761027
> 
> BUG=171891
> TEST=manual
> Run: 
> out/Debug/interactive_ui_tests --gtest_filter='BookmarkBarViewTest20.*'
> 
> Review URL: https://chromiumcodereview.appspot.com/12087075

TBR=sschmitz@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182067

[tfarina, 2013-02-13 00:08:42]

On Tue, Feb 12, 2013 at 10:07 PM,  <raymes@chromium.org> wrote:
> Reviewers: sschmitz,
>
> Description:
> Revert 182037
Don't revert without describing the reason in the commit message!

>>
>> Create unit-test for exiting context menus via mouse button
>
>
>> Added a unit-test to BookmarkBarViewTest. It opens a context menu. The
>> menu
>> is dismissed by clicking the mouse outside of it. The underlying view gets
>> the mouse event after the context menu has exited.
>
>
>> See also: https://chromiumcodereview.appspot.com/11761027
>
>
>> BUG=171891
>> TEST=manual
>> Run:
>> out/Debug/interactive_ui_tests --gtest_filter='BookmarkBarViewTest20.*'
>
>
>> Review URL: https://chromiumcodereview.appspot.com/12087075
>
>
> TBR=sschmitz@chromium.org
>
> Please review this at https://codereview.chromium.org/12207141/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>   MM    chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
>
>



-- 
Thiago

[raymes, 2013-02-13 00:10:28]

Sorry =\

For reference (at least on the codereview) it was for the test failure:
BookmarkBarViewTest20.ContextMenuExitTest:
browser\ui\views\bookmarks\bookmark_bar_view_test.cc(1644): error: Value of: 2
Expected: test_view_->press_count()
Which is: 1

in:
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/buil...

On Tue, Feb 12, 2013 at 4:08 PM, Thiago Farina <tfarina@chromium.org> wrote:
> On Tue, Feb 12, 2013 at 10:07 PM,  <raymes@chromium.org> wrote:
>> Reviewers: sschmitz,
>>
>> Description:
>> Revert 182037
> Don't revert without describing the reason in the commit message!
>
>>>
>>> Create unit-test for exiting context menus via mouse button
>>
>>
>>> Added a unit-test to BookmarkBarViewTest. It opens a context menu. The
>>> menu
>>> is dismissed by clicking the mouse outside of it. The underlying view gets
>>> the mouse event after the context menu has exited.
>>
>>
>>> See also: https://chromiumcodereview.appspot.com/11761027
>>
>>
>>> BUG=171891
>>> TEST=manual
>>> Run:
>>> out/Debug/interactive_ui_tests --gtest_filter='BookmarkBarViewTest20.*'
>>
>>
>>> Review URL: https://chromiumcodereview.appspot.com/12087075
>>
>>
>> TBR=sschmitz@chromium.org
>>
>> Please review this at https://codereview.chromium.org/12207141/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>>
>> Affected files:
>>   MM    chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
>>
>>
>
>
>
> --
> Thiago

[sschmitz, 2013-02-13 00:11:25]

I added a unit-test that should be excluded from Windows.


On Tue, Feb 12, 2013 at 4:10 PM, Raymes Khoury <raymes@chromium.org> wrote:

> Sorry =\
>
> For reference (at least on the codereview) it was for the test failure:
> BookmarkBarViewTest20.ContextMenuExitTest:
> browser\ui\views\bookmarks\bookmark_bar_view_test.cc(1644): error: Value
> of: 2
> Expected: test_view_->press_count()
> Which is: 1
>
> in:
>
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/buil...
>
> On Tue, Feb 12, 2013 at 4:08 PM, Thiago Farina <tfarina@chromium.org>
> wrote:
> > On Tue, Feb 12, 2013 at 10:07 PM,  <raymes@chromium.org> wrote:
> >> Reviewers: sschmitz,
> >>
> >> Description:
> >> Revert 182037
> > Don't revert without describing the reason in the commit message!
> >
> >>>
> >>> Create unit-test for exiting context menus via mouse button
> >>
> >>
> >>> Added a unit-test to BookmarkBarViewTest. It opens a context menu. The
> >>> menu
> >>> is dismissed by clicking the mouse outside of it. The underlying view
> gets
> >>> the mouse event after the context menu has exited.
> >>
> >>
> >>> See also: https://chromiumcodereview.appspot.com/11761027
> >>
> >>
> >>> BUG=171891
> >>> TEST=manual
> >>> Run:
> >>> out/Debug/interactive_ui_tests --gtest_filter='BookmarkBarViewTest20.*'
> >>
> >>
> >>> Review URL: https://chromiumcodereview.appspot.com/12087075
> >>
> >>
> >> TBR=sschmitz@chromium.org
> >>
> >> Please review this at https://codereview.chromium.org/12207141/
> >>
> >> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
> >>
> >> Affected files:
> >>   MM    chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
> >>
> >>
> >
> >
> >
> > --
> > Thiago
>