Reduce allocation of ArrayNode-s where a GrowableArray could be used instead.

runtime/vm/ast.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_AST_H_
 #define VM_AST_H_
 
 #include "platform/assert.h"
 #include "vm/allocation.h"
 #include "vm/growable_array.h"
@@ skipping 251 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(ArgumentDefinitionTestNode);
 };
 
 
 class ArrayNode : public AstNode {
  public:
   ArrayNode(intptr_t token_pos, const AbstractType& type)
       : AstNode(token_pos),
         type_(type),
         elements_() {
-    ASSERT(type_.IsZoneHandle());
-    ASSERT(!type_.IsNull());
-    ASSERT(type_.IsFinalized());
-    // Type may be uninstantiated when creating a generic list literal.
-    ASSERT((type.arguments() == AbstractTypeArguments::null()) ||
-           ((AbstractTypeArguments::Handle(type.arguments()).Length() == 1)));
+    CheckFields();
+  }
+  ArrayNode(intptr_t token_pos,
+            const AbstractType& type,
+            const GrowableArray<AstNode*>& elements)
+      : AstNode(token_pos),
+        type_(type),
+        elements_(elements.length()) {
+    CheckFields();
+    for (intptr_t i = 0; i < elements.length(); i++) {
+      elements_.Add(elements[i]);
+    }
   }
 
   void VisitChildren(AstNodeVisitor* visitor) const;
 
   intptr_t length() const { return elements_.length(); }
 
   AstNode* ElementAt(intptr_t index) const { return elements_[index]; }
   void SetElementAt(intptr_t index, AstNode* value) {
     elements_[index] = value;
   }
   void AddElement(AstNode* expr) { elements_.Add(expr); }
 
   const AbstractType& type() const { return type_; }
 
   DECLARE_COMMON_NODE_FUNCTIONS(ArrayNode);
 
  private:
   const AbstractType& type_;
   GrowableArray<AstNode*> elements_;
 
+  void CheckFields() {
+    ASSERT(type_.IsZoneHandle());
+    ASSERT(!type_.IsNull());
+    ASSERT(type_.IsFinalized());
+    // Type may be uninstantiated when creating a generic list literal.
+    ASSERT((type_.arguments() == AbstractTypeArguments::null()) ||
+           ((AbstractTypeArguments::Handle(type_.arguments()).Length() == 1)));
+  }
+
   DISALLOW_IMPLICIT_CONSTRUCTORS(ArrayNode);
 };
 
 
 class LiteralNode : public AstNode {
  public:
   LiteralNode(intptr_t token_pos, const Instance& literal)
       : AstNode(token_pos), literal_(literal) {
     ASSERT(literal_.IsNotTemporaryScopedHandle());
     ASSERT(literal_.IsSmi() || literal_.IsOld());
@@ skipping 1400 matching lines @@
   const LocalVariable& context_var_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(InlinedFinallyNode);
 };
 
 }  // namespace dart
 
 #undef DECLARE_COMMON_NODE_FUNCTIONS
 
 #endif  // VM_AST_H_