Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: runtime/vm/service/service.md

Issue 1220713008: Fixes to the service.md doc. Various minor changes discovered while (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service/service.md
diff --git a/runtime/vm/service/service.md b/runtime/vm/service/service.md
index 5815bf4c38f879fc82c980e429576814ea908d5c..8acb05b9c22fd5621d026251d491bdfcb93055e5 100644
--- a/runtime/vm/service/service.md
+++ b/runtime/vm/service/service.md
@@ -836,7 +836,7 @@ class @Code extends @Object {
_@Code_ is a reference to a _Code_ object.
```
-class @Code extends @Object {
+class Code extends @Object {
devoncarew 2015/06/29 18:38:20 This is a dup of the above definition. Should this
turnidge 2015/06/29 22:07:01 This one is a bit odd, since it only differs in it
devoncarew 2015/06/29 22:22:22 Yup, totally. I just wanted to make sure that it w
turnidge 2015/06/29 22:55:36 Acknowledged.
// A name for this code object.
string name;
@@ -1136,10 +1136,10 @@ A _Flag_ represents a single VM command line flag.
```
class FlagList extends Response {
// A list of all flags which are set to default values.
- unmodifiedFlags []Flag
+ Flag[] unmodifiedFlags;
// A list of all flags which have been modified by the user.
- modifiedFlags []Flag
+ Flag[] modifiedFlags;
}
```
@@ -1170,11 +1170,10 @@ class @Function extends @Object {
@Library|@Class|@Function owner;
// Is this function static?
- bool static
+ bool static;
// Is this function const?
bool const;
-
}
```
@@ -1182,7 +1181,6 @@ An _@Function_ is a reference to a _Function_.
```
-// A Dart language function.
devoncarew 2015/06/29 18:38:20 Already doc'd below, and none of the other definit
turnidge 2015/06/29 22:07:01 Acknowledged.
class Function extends Object {
// The name of this function.
string name;
@@ -1269,7 +1267,7 @@ class @Instance extends @Object {
//
// Provided for instance kinds:
// RegExp
- @String pattern [optional];
+ String pattern [optional];
}
```
@@ -1391,14 +1389,14 @@ class Instance extends Object {
//
// Provided for instance kinds:
// RegExp
- @String pattern [optional];
-
+ String pattern [optional];
+
// The key for a WeakProperty instance.
//
// Provided for instance kinds:
// WeakProperty
@Instance propertyKey [optional];
-
+
// The key for a WeakProperty instance.
//
// Provided for instance kinds:
@@ -1446,7 +1444,7 @@ An _Instance_ represents an instance of the Dart language class _Object_.
### InstanceKind
```
-enum {
+enum InstanceKind {
// A general instance of the Dart class Object.
PlainInstance,
@@ -1698,7 +1696,7 @@ A _Null_ object represents the Dart language value null.
class @Object extends Response {
// A unique identifier for an Object. Passed to the
// getObject RPC to load this Object.
- string id
+ string id;
}
```
@@ -1832,7 +1830,7 @@ tokenPos | line | column
```
class SourceLocation extends Response {
- // The script contaiinging the source location.
+ // The script containing the source location.
@Script script;
// The first token of the location.
@@ -1849,7 +1847,7 @@ some script.
### Stack
```
-class Stack {
+class Stack extends Response {
Frame[] frames;
Message[] messages;
}
@@ -1953,10 +1951,10 @@ class VM extends Response {
// The time that the VM started in milliseconds since the epoch.
//
// Suitable to pass to DateTime.fromMillisecondsSinceEpoch.
- int startTime
+ int startTime;
// A list of isolates running in the VM.
- @Isolate[] isolates
+ @Isolate[] isolates;
}
```
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698